Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Resolve Swift method name conflicts by adding missing namespace #25927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2024
Merged

Resolve Swift method name conflicts by adding missing namespace #25927

merged 1 commit into from
Jul 18, 2024

Conversation

@yeatse
Copy link
Contributor

@yeatse yeatse commented Jul 17, 2024

Fixes #25926

We should include namespaces when generating swift bindings to avoid name conflicts.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@yeatse yeatse changed the title fix: resolve Swift method name conflicts by adding missing namespace Resolve Swift method name conflicts by adding missing namespace Jul 17, 2024
@yeatse yeatse mentioned this pull request Jul 17, 2024
Closed
@asmorkalov
Copy link
Contributor

asmorkalov commented Jul 17, 2024

@komakai @VadimLevin Could you take a look?

komakai
komakai approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@komakai komakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 18, 2024
@asmorkalov asmorkalov merged commit 0020831 into opencv:4.x Jul 18, 2024
@yeatse yeatse deleted the fix-swift-name branch July 18, 2024 10:43
@asmorkalov asmorkalov mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@komakai komakai komakai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: swift/objc bindings

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

objc bindings generator generates conflicting swift method names

3 participants

@yeatse @asmorkalov @komakai