Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Kumataro
Copy link
Contributor

Close #26017

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-alalek opencv-alalek added the category: documentation Documentation fix or update label Aug 10, 2024
@Kumataro
Copy link
Contributor Author

Kumataro commented Aug 10, 2024

Basically my fix works well, but I'm sorry I notice there are small problem.
I need some time to consider expressing it in Python.

When "Python" button in Code section is pushed, "OpenCV Theory" section is broken.

[Before] https://docs.opencv.org/4.10.0/d3/d96/tutorial_basic_geometric_drawing.html

  • Remove "OpenCV Theory" section at all.

[After] https://pullrequest.opencv.org/buildbot/export/pr/26018/docs/d3/d96/tutorial_basic_geometric_drawing.html

  • It feels strange because only the code example part is deleted.

@Kumataro
Copy link
Contributor Author

Kumataro commented Aug 10, 2024

@asmorkalov asmorkalov self-requested a review August 12, 2024 08:10
@asmorkalov asmorkalov self-assigned this Aug 12, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Aug 12, 2024
@asmorkalov asmorkalov merged commit 2fcea41 into opencv:4.x Aug 12, 2024
@asmorkalov asmorkalov mentioned this pull request Aug 27, 2024
thewoz pushed a commit to CobbsLab/OPENCV that referenced this pull request Feb 13, 2025
doc: remove duplicated OpenCV Theory at ToC in Basic Drawing opencv#26018

Close opencv#26017

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doc: ToC has duplicated "OpenCV Theory" at Basic Drawing

3 participants