imgproc: use double to determine whether the corners points are within src #26022
Conversation
|
It seems that CI doesn't work well. Is there anything I can help ? I had been tried to re-run CI/CD with new git commit and push, --- Added comment |
| bool empty() const; | ||
|
|
||
| //! conversion to another data type | ||
| template<typename _Tp2> operator Rect_<_Tp2>() const; |
There was a problem hiding this comment.
Did you try explicit for conversion operator instead? (to avoid unexpected conversions)
(since C++11: https://en.cppreference.com/w/cpp/language/cast_operator )
There was a problem hiding this comment.
Did you try explicit for conversion operator instead? (to avoid unexpected conversions)
I think it is not easy, because cv::Point and cv::Rect is used for drawing functions in imgproc, so there are many side-effetcs not only OpenCV library but also user-applications. (I would like to do that if possible...)
Following are trial codes, but it doesn't include some modules (cuda*, hdf, ...).
Imgproc: use double to determine whether the corners points are within src opencv#26022 close opencv#26016 Related opencv/opencv_contrib#3778 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
close #26016
Related opencv/opencv_contrib#3778
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.