Thanks to visit codestin.com
Credit goes to github.com

Skip to content

3rdparty: NDSRVP - Part 2: Filter #26088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

3rdparty: NDSRVP - Part 2: Filter #26088

merged 1 commit into from
Sep 11, 2024

Conversation

@Junyan721113
Copy link
Contributor

@Junyan721113 Junyan721113 commented Aug 30, 2024

Previous context

From PR #25167:

Part 2 (Next PR)

Rough Estimate. Todo List May Change.

Filter implementation, further filter-applying functions would be based on this.

Performance test results

The performance test sample may be lack of CV_16U in src_type and dst_type.

Geometric mean (ms)

Name of Test opencv perf imgproc TestFilter blank opencv perf imgproc TestFilter rvp opencv perf imgproc TestFilter blank vs opencv perf imgproc TestFilter rvp (x-factor)
Filter2d::TestFilter2d::(320x240, 3, BORDER_CONSTANT) 19.399 17.532 1.11
Filter2d::TestFilter2d::(320x240, 3, BORDER_REFLECT_101) 19.420 17.514 1.11
Filter2d::TestFilter2d::(320x240, 3, BORDER_REPLICATE) 19.358 17.465 1.11
Filter2d::TestFilter2d::(320x240, 5, BORDER_CONSTANT) 38.986 36.231 1.08
Filter2d::TestFilter2d::(320x240, 5, BORDER_REFLECT_101) 38.969 35.967 1.08
Filter2d::TestFilter2d::(320x240, 5, BORDER_REPLICATE) 38.903 35.894 1.08
Filter2d::TestFilter2d::(1920x1080, 3, BORDER_CONSTANT) 587.769 522.943 1.12
Filter2d::TestFilter2d::(1920x1080, 3, BORDER_REFLECT_101) 564.358 520.681 1.08
Filter2d::TestFilter2d::(1920x1080, 3, BORDER_REPLICATE) 565.635 520.763 1.09
Filter2d::TestFilter2d::(1920x1080, 5, BORDER_CONSTANT) 1188.954 1088.148 1.09
Filter2d::TestFilter2d::(1920x1080, 5, BORDER_REFLECT_101) 1190.871 1086.212 1.10
Filter2d::TestFilter2d::(1920x1080, 5, BORDER_REPLICATE) 1189.285 1086.028 1.10

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from mshabunin August 30, 2024 05:59
@asmorkalov
Copy link
Contributor

asmorkalov commented Sep 6, 2024

@mshabunin Friendly reminder.

1 similar comment
@asmorkalov
Copy link
Contributor

asmorkalov commented Sep 11, 2024

@mshabunin Friendly reminder.

@asmorkalov asmorkalov added this to the 4.11.0 milestone Sep 11, 2024
@asmorkalov asmorkalov merged commit 7de3a8e into opencv:4.x Sep 11, 2024
@asmorkalov asmorkalov mentioned this pull request Sep 20, 2024
Merged
@Junyan721113 Junyan721113 mentioned this pull request Oct 25, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

optimization platform: riscv

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Junyan721113 @asmorkalov @mshabunin