Excluded nullptr leak to arithmetic HAL got from empty Mat. #26125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19c47e6 to
307dc2a
Compare
mshabunin
approved these changes
Sep 6, 2024
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Overall looks good to me.
Maybe it would be useful to have tests for these cases.
| CV_INSTRUMENT_REGION(); | ||
|
|
||
| CV_Assert(src1.empty() == src2.empty()); | ||
| if (src1.empty() && src2.empty()) |
Contributor
There was a problem hiding this comment.
Silent processing of empty Mat is error-prone. See #8300
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution similar to #12004
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.