Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed CUDA StereoBM initialization #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fixed CUDA StereoBM initialization #3598

merged 1 commit into from
Dec 1, 2023

Conversation

@asmorkalov
Copy link
Contributor

@asmorkalov asmorkalov commented Nov 23, 2023 •
edited
Loading

Port of opencv/opencv#24574

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from mshabunin November 23, 2023 12:57
@asmorkalov
Copy link
Contributor Author

asmorkalov commented Nov 23, 2023

cc @cudawarped

@cudawarped
Copy link
Contributor

cudawarped commented Nov 23, 2023 •
edited
Loading

The SSD buffer is re-sized in ::compute() method with line cuda::ensureSizeIsEnough(left.size(), CV_32SC1, minSSD_); for each input size. The mentioned issue is copy-paste bug. It's good luck that left.height == disparity.height == minSSD_.height. That's why the issue was not visible before. I created the follow-up patch in contrib for 4.x: #3598

My mistake I see that ensureSizeIsEnough alters the row and col params while keeping the underlying memory untouched, I had wrongly assumed that row and col would also stay the same if the size was enough.

@asmorkalov asmorkalov mentioned this pull request Nov 23, 2023
Merged
6 tasks
@asmorkalov asmorkalov merged commit 66d93ce into opencv:4.x Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

No one assigned

Labels

bug category: cuda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @cudawarped