Thanks to visit codestin.com
Credit goes to github.com

Skip to content

cudacodec: fix #3711 (update for Nvidia Video Codec SDK 12.2) #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2024
Merged

cudacodec: fix #3711 (update for Nvidia Video Codec SDK 12.2) #3717

merged 1 commit into from
Apr 15, 2024

Conversation

@cudawarped
Copy link
Contributor

@cudawarped cudawarped commented Apr 10, 2024 •
edited
Loading

fix #3711 by updating NVEncoder.cpp to reflect the changes contained in Nvidia's sample code.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review April 10, 2024 13:45
@asmorkalov asmorkalov self-assigned this Apr 10, 2024
@asmorkalov asmorkalov merged commit 4c810a9 into opencv:4.x Apr 15, 2024
@asmorkalov asmorkalov mentioned this pull request Apr 16, 2024
Merged
@cudawarped cudawarped mentioned this pull request Feb 4, 2025
Merged
6 tasks
@Jerry-Master
Copy link

Jerry-Master commented Mar 13, 2025 •
edited
Loading

This PR fails for version 13.0 due to the way the if else is coded. Using #if ((NVENCAPI_MAJOR_VERSION >= 12 && NVENCAPI_MINOR_VERSION >= 2) || NVENCAPI_MAJOR_VERSION >= 13) should fix that issue.

@cudawarped
Copy link
Contributor Author

cudawarped commented Mar 13, 2025

@Jerry-Master See #3880

@Jerry-Master
Copy link

Jerry-Master commented Mar 13, 2025

I was compiling version 4.11, it is good to know that it is fixed in the latest version. Thanks for the fast response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: cuda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cudacodec: VideoWriter fails to compile with Nvidia Video Codec SDK 12.2

3 participants

@cudawarped @Jerry-Master @asmorkalov