Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove deprecated download_url field from badges app#2793

Merged
GlugovGrGlib merged 1 commit intoopenedx:release/teakfrom
raccoongang:cmltawt0/teak/remove-download_url
Jun 10, 2025
Merged

fix: remove deprecated download_url field from badges app#2793
GlugovGrGlib merged 1 commit intoopenedx:release/teakfrom
raccoongang:cmltawt0/teak/remove-download_url

Conversation

@cmltaWt0
Copy link
Contributor

@cmltaWt0 cmltaWt0 commented Jun 7, 2025

Backport of #2792

Removed field causes the migration issue:

<class 'credentials.apps.badges.admin.AccredibleBadgeAdmin'>: (admin.E035) The value of 'readonly_fields[3]' is not a callable, an attribute of 'AccredibleBadgeAdmin', or an attribute of 'badges.AccredibleBadge'.
<class 'credentials.apps.badges.admin.CredlyBadgeAdmin'>: (admin.E035) The value of 'readonly_fields[3]' is not a callable, an attribute of 'CredlyBadgeAdmin', or an attribute of 'badges.CredlyBadge'.

Deprecation PRs:

Changes:

  • For settings/test.py
    • set BADGES_ENABLED = True
    • set BADGES_CONFIG["accredible"]["USE_SANDBOX"] = True

TODO:

  • add migrations check in CI

Run JavaScript tests locally with Karma

There is work being done on a fix to get Karma to run in CI. Until then, however, contributors are required to run these tests locally.

  • Make sure you are inside the devstack container
  • Run make test-karma
  • All tests pass

@cmltaWt0
fix: remove deprecated download_url field from badges app
72c9f4f 
Removed field causes the migration issue:
```
<class 'credentials.apps.badges.admin.AccredibleBadgeAdmin'>: (admin.E035) The value of 'readonly_fields[3]' is not a callable, an attribute of 'AccredibleBadgeAdmin', or an attribute of 'badges.AccredibleBadge'.
<class 'credentials.apps.badges.admin.CredlyBadgeAdmin'>: (admin.E035) The value of 'readonly_fields[3]' is not a callable, an attribute of 'CredlyBadgeAdmin', or an attribute of 'badges.CredlyBadge'.
````
Deprecation PRs:
- openedx#2747
- openedx#2748

Changes:
- For settings/test.py
  - set BADGES_ENABLED = True
  - set BADGES_CONFIG["accredible"]["USE_SANDBOX"] = True

TODO:
- add migrations check in CI
@cmltaWt0 cmltaWt0 requested a review from a team as a code owner June 7, 2025 11:29
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 7, 2025

Thanks for the pull request, @cmltaWt0!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jun 7, 2025
@cmltaWt0 cmltaWt0 requested a review from mariajgrimaldi June 7, 2025 11:30
@cmltaWt0 cmltaWt0 added release testing Affects the upcoming release (attention needed) release blocker Blocks the upcoming release (fix needed) labels Jun 7, 2025
@cmltaWt0 cmltaWt0 mentioned this pull request Jun 7, 2025
Closed
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Jun 9, 2025

FYI @farhaanbukhsh

@cmltaWt0 cmltaWt0 linked an issue Jun 9, 2025 that may be closed by this pull request
[Test failure] <NO TEST ID>: Credentials Badges can't be enabled openedx/wg-build-test-release#523
Closed
@GlugovGrGlib GlugovGrGlib merged commit 7fd3268 into openedx:release/teak Jun 10, 2025
4 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GlugovGrGlib GlugovGrGlib GlugovGrGlib approved these changes

@farhaanbukhsh farhaanbukhsh Awaiting requested review from farhaanbukhsh

+2 more reviewers

@justinhynes justinhynes justinhynes approved these changes

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U release blocker Blocks the upcoming release (fix needed) release testing Affects the upcoming release (attention needed)

Projects

Aperture-Maintained
Status: Done
Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Test failure] <NO TEST ID>: Credentials Badges can't be enabled

5 participants

@cmltaWt0 @openedx-webhooks @mariajgrimaldi @justinhynes @GlugovGrGlib