Bug fix: video end time proper seek beyond. #1480
Conversation
There was a problem hiding this comment.
This should correspond to <source> elements, which live inside <video> tags, I believe. As for why you're removing them, that I don't know. If the tests still pass without this line, then the line should be removed from the tests; if the tests fail without this line, then you know why it was needed. :)
There was a problem hiding this comment.
source tags should be removed to avoid memory leak bug that we had before. Removing of source tag, not video, stops loading video source and clears the memory.
|
Once you mock the Javascript clock, I am 👍 on this PR. |
|
Please update |
|
@polesye I will update |
There was a problem hiding this comment.
use Number instead of speedFactor dict:
this.videoPlayer.startTime /= Number(this.speed);Fix bug when the user clicks on the video time-line either before or after the specified end time, it jumps to the very beginning of the video. BLD-392
…t_navigation Bug fix: video end time proper seek beyond.
Title
"clicking outside of start/end time sends user to beginning of the video, instead of where she clicked."
https://edx-wiki.atlassian.net/browse/BLD-392
Description
A related issue (bug?) is that when the user clicks on the video timeline either before or after the specified end time, it jumps to the very beginning of the video (even if it's before the specified start time).
Technical details
This seems to be a YouTube feature. When start/end time is specified, the video doesn't play beyond the end time, and restarts playing (upon finish) from the beginning.
Tested with vanilla Google code example + start/end time parameters at http://jsfiddle.net/4hVWv/ .
Solution
Do not use YouTube API
startandendproperties. Handle these cases manually. I.e. pausing the video when the time reachesendtime.Reviewers