Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support a URL address as FOOTER_ORGANIZATION_LOGO #20001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

Support a URL address as FOOTER_ORGANIZATION_LOGO #20001

merged 1 commit into from
Jul 30, 2019

Conversation

mahyard
Copy link
Contributor

@mahyard mahyard commented Mar 14, 2019

Hi,
this is a fix for the problem reported in this google-groups thread

More information:
without this code change it is not possible to give an absolute URL to the FOOTER_ORGANIZATION_LOGO in settings. doing so will produce an HTTP 500 error in homepage and any other place branding.api.get_footer() has been called.

@ormsbee could you please take a look?

@openedx-webhooks
Copy link

Thanks for the pull request, @mahyard! I've created OSPR-3206 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Mar 14, 2019
@natabene
Copy link
Contributor

@mahyard Thank you for your contribution. Please let me know once all checks are green and it is ready for review.

@natabene
Copy link
Contributor

jenkins run all

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Mar 14, 2019
@mahyard
Copy link
Contributor Author

mahyard commented May 7, 2019

@natabene can I ask to run tests again please.
I came here after a while today seems that they are removed. perhaps because they were outdated.

@natabene
Copy link
Contributor

natabene commented May 7, 2019

jenkins run all

@mahyard mahyard force-pushed the master branch 3 times, most recently from 9f4ccff to 2a4f067 Compare May 12, 2019 14:57
@mahyard
Copy link
Contributor Author

mahyard commented May 13, 2019

jenkins run all

1 similar comment
@natabene
Copy link
Contributor

jenkins run all

@mahyard
Copy link
Contributor Author

mahyard commented May 14, 2019

@natabene
seems my PRs issue with bokchoy tests still persists. :)
would you run it again please? I have rebased code to be synced with master.

@natabene
Copy link
Contributor

jenkins run all

@mahyard
Copy link
Contributor Author

mahyard commented May 14, 2019

@natabene,
So again this error differs from what I got during last test.
all these tests have passed with green check in my devstack.

@natabene
Copy link
Contributor

@edx/testeng Could you help us here with the bokchoy test?

@jmbowman
Copy link
Contributor

Looks like that test has been intermittently failing, starting the process to remove it now. You can go ahead and ignore that failure.

@natabene
Copy link
Contributor

@ormsbee This is ready for your review, should be quick

@natabene natabene requested a review from ormsbee May 14, 2019 17:53
@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 14, 2019
@mahyard
Copy link
Contributor Author

mahyard commented May 19, 2019

Excuse me @ormsbee,
I think you should have a deep review on the test-case I modified. I'm sure it's not a good change and you can suggest a better one.
thank you for your attention

@openedx openedx deleted a comment from openedx-webhooks May 24, 2019
@natabene
Copy link
Contributor

@edx/fedx-team Team, could you give this a look? CC @georgebabey

@mahyard mahyard changed the title WIP: Support a URL address as FOOTER_ORGANIZATION_LOGO Support a URL address as FOOTER_ORGANIZATION_LOGO Jul 16, 2019
@mahyard
Copy link
Contributor Author

mahyard commented Jul 16, 2019

thank you @natabene,
I've just changed some commented lines and rebased to the latest version of master branch,
So I think it's ready to be merged.

@natabene
Copy link
Contributor

jenkins run all

@natabene
Copy link
Contributor

Please address js failure, @mahyard

@openedx-webhooks openedx-webhooks added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 16, 2019
@mahyard
Copy link
Contributor Author

mahyard commented Jul 17, 2019 •
edited
Loading

what? These errors doesn't look to be generated because of my changes.
unfortunately I have a problem with my devstack right now.
would you mind if I ask you to rerun JS tests?
or maybe I have to rebase my branch once again?

@natabene
Copy link
Contributor

jenkins run js

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@natabene
Copy link
Contributor

@edx/fedx-team Do you guys want to review this? It is ready for review and merge.

@natabene natabene requested a review from a team July 17, 2019 14:31
@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jul 17, 2019
@mahyard
Copy link
Contributor Author

mahyard commented Jul 24, 2019 •
edited
Loading

@edx/fedx-team Do you guys want to review this? It is ready for review and merge.

@natabene A long time have been passed from this PR.

@natabene
Copy link
Contributor

@georgebabey When you have a chance, can you let me know if fedx team can review this?

@natabene
Copy link
Contributor

@nasthagiri Can you give this a look when you have a chance?

@mahyard
Copy link
Contributor Author

mahyard commented Jul 29, 2019

hello @natabene ,
Happy Monday
who is the next one to ask a review?

@natabene
Copy link
Contributor

@mahyard This is on our radar, I have queued it for the appropriate team, but it might take a while to review.

@nasthagiri
Copy link
Contributor

@mahyard Thank you for reporting this issue, and even more so, proactively taking the time to contribute a fix (to the code and to the mocked test). We very much appreciate your effort. I am merging this PR now.

@nasthagiri nasthagiri merged commit 900b7e2 into openedx:master Jul 30, 2019
@openedx-webhooks
Copy link

@mahyard 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, July 30, 2019.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/STAGE_edxapp_M-D

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@uzairr
Copy link
Contributor

uzairr commented Jul 31, 2019

@ormsbee @mahyard The footer logos (edX logo, mobile app logos) are breaking due to this PR because Now, url path of the logos are not generated as they should be.Expected url path is https://prod-edxapp.edx-cdn.org/static/images/app/app_store_badge_135x40.d0558d910630.svg
instead of https://courses.edx.org/https://prod-edxapp.edx-cdn.org/static/images/app/app_store_badge_135x40.d0558d910630.svg
I am creating a revert PR of it.

CC: @nasthagiri @fysheets @waheedahmed

@uzairr uzairr mentioned this pull request Jul 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ormsbee ormsbee ormsbee approved these changes

Assignees
No one assigned
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mahyard @openedx-webhooks @natabene @jmbowman @ormsbee @michaelyoungstrom @edx-status-bot @nasthagiri @edx-pipeline-bot @uzairr