Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mahyard
Copy link
Contributor

@mahyard mahyard commented Jan 26, 2020

No description provided.

@openedx-webhooks
Copy link

Thanks for the pull request, @mahyard! I've created OSPR-4056 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jan 26, 2020
@natabene
Copy link
Contributor

@mahyard Thank you for your contribution. Please let me know once all tests are green.

@natabene
Copy link
Contributor

jenkins run all

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Jan 27, 2020
@mahyard
Copy link
Contributor Author

mahyard commented Jan 28, 2020

YW @natabene
I don't see any specific failure.
Could you rerun python tests please? Thanks

@natabene
Copy link
Contributor

jenkins run all

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@natabene
Copy link
Contributor

@mahyard I am queueing it for a review now.

@openedx-webhooks openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Jan 28, 2020
@nedbat nedbat merged commit 8207311 into openedx:master Feb 5, 2020
@openedx-webhooks
Copy link

@mahyard 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants