Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

robrap
Copy link
Contributor

@robrap robrap commented Feb 4, 2020

BOM-897

Please consider the following when opening a pull request:

  • Link to the relevant JIRA ticket(s) and tag any relevant team(s).
  • Squash your changes down into one or more discrete commits.
    In each commit, include description that could help a developer
    several months from now.
  • If running make upgrade, run as close to the time of merging as possible
    to avoid accidentally downgrading someone else's package.
    Put the output of make upgrade in its own separate commit,
    decoupled from other code changes.
  • Aim for comprehensive test coverage, but remember that
    automated testing isn't a substitute for manual verification.
  • Carefully consider naming, code organization, dependencies when adding new code.
    Code that is amenable to refactoring and improvement benefits all platform developers,
    especially given the size and scope of edx-platform.
    Consult existing Architectural Decision Records (ADRs),
    including those concerning the app(s) you are changing and
    those concerning edx-platform as a whole.

@robrap robrap requested a review from a team February 4, 2020 15:03
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine but as we said in person, I think we should just pull this up to the system level setting instead.

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@robrap robrap merged commit a49ff5a into master Feb 4, 2020
@robrap robrap deleted the robrap/add-jwt-auth-for-third-party-auth branch February 4, 2020 15:47
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants