-
-
Notifications
You must be signed in to change notification settings - Fork 321
Support new chart parameter: interpolation #3920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support new chart parameter: interpolation #3920
Conversation
Signed-off-by: Holger Friedrich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So interpolation is a new Sitemap chart parameter that just needs to be added to the URL when getting charts from the server? It case this change would be fine, however since the last release of the app, @maniac103 implemented client-side charts, which should also use this new parameter.
|
Yes, exactly, this is a new parameter to be appended to the URL. I don't know about then new client-side rendering. Maybe @maniac103 could give me some guidance. |
|
It seems that the client side chart library doesn't support interpolation and it needs to be done manually before sending the values to the chart. |
It does: there's |
c8c16f0 to
064c514
Compare
Signed-off-by: Holger Friedrich <[email protected]>
064c514 to
92565c1
Compare
|
@mueller-ma Should we split this up and fix the server side charts first? @maniac103 I don't see how I could implement the client-side charts. Would you be willing to guide me, or could you take over the implementation? We still have a few showstoppers for the OH5.0 release to resolve. |
|
@holgerfriedrich Yes, I can complete this PR, assuming I can push to your branch. |
|
Thanks a lot. I added you as a collaborator. |
Signed-off-by: Danny Baumann <[email protected]>
Signed-off-by: Danny Baumann <[email protected]>
|
@holgerfriedrich I added the client side rendering handling. It's untested for now though, as {
"widgetId": "030404",
"type": "Chart",
"visibility": true,
"label": "Füllstand Zisterne (Liter) [5643 l]",
"labelSource": "ITEM_LABEL",
"icon": "cistern",
"staticIcon": false,
"pattern": "%d l",
"unit": "",
"mappings": [
],
"refresh": 1800000,
"service": "influxdb",
"period": "3D",
"item": {
"link": "http://192.168.100.10:8080/rest/items/CisternFillingLiter",
"state": "5643.00",
"stateDescription": {
"minimum": 0.0,
"maximum": 1.0E+8,
"pattern": "%d l",
"readOnly": true,
"options": [
]
},
"lastState": "5638.00",
"lastStateUpdate": 1753096820370,
"lastStateChange": 1753096820370,
"type": "Number",
"name": "CisternFillingLiter",
"label": "Füllstand Zisterne (Liter)",
"category": "cistern",
"tags": [
"Measurement",
"Water"
],
"groupNames": [
"CisternFillSensor",
"GroupPersistenceChartable"
]
},
"widgets": [
]
}This is with no explicit interpolation set. I tried to set interpolation (via UI), but Main UI doesn't save the page once I've done that. (FWIW, openhab/openhab-core#4610 not making any changes to |
Support new core feature openhab/openhab-core#4610
Partly fixes openhab/openhab-webui#3277
This is totally untested, I don't have proper dev setup at hand.