Opening Hat Dialect for Handling Barriers and Shared/Private Memory #560
Conversation
|
👋 Welcome back jfumero! A progress list of the required criteria for merging this PR into |
|
@jjfumero This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
|
||
| @Override | ||
| public TypeElement resultType() { | ||
| return typeElement; |
There was a problem hiding this comment.
| return typeElement; | |
| return JavaType.VOID; |
Webrevs
|
This patch creates a new dialect for HAT for handling barriers, local (or shared) memory declaration of types, and private memory declariton. It extends the
Ops provided by code-reflection with a newHatOpthe dialect.It is enabled by default.
TODO: We should move the Hat Config to a common place to be able to use it in the Hat core module, not just in the code gen.
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/560/head:pull/560$ git checkout pull/560Update a local copy of the PR:
$ git checkout pull/560$ git pull https://git.openjdk.org/babylon.git pull/560/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 560View PR using the GUI difftool:
$ git pr show -t 560Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/560.diff
Using Webrev
Link to Webrev Comment