Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed XStreamAlias for ignore_attribute #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvanrijn merged 3 commits into from
Mar 19, 2021
Merged

Fixed XStreamAlias for ignore_attribute #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b0dcd
Fixed XStreamAlias for ignore_attribute
mwever Mar 17, 2021
ca296f1
Added junit test for checking that ignore attribute is not empty for
mwever Mar 17, 2021
5761733
Merge pull request #48 from openml/develop
janvanrijn Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apiconnector/src/main/java/org/openml/apiconnector/xml/DataSetDescription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public class DataSetDescription extends OpenmlApiResponse {
@XStreamAlias("oml:row_id_attribute")
private String row_id_attribute;

@XStreamImplicit(itemFieldName = "ignore_attribute")
@XStreamImplicit(itemFieldName = "oml:ignore_attribute")
private String[] ignore_attribute;

@XStreamAlias("oml:version_label")
Expand Down
20 changes: 15 additions & 5 deletions apiconnector/src/test/java/apiconnector/TestDataFunctionality.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@
*/
package apiconnector;

import static org.junit.Assert.*;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.io.ByteArrayInputStream;
import java.io.File;
Expand Down Expand Up @@ -52,6 +55,7 @@
import org.openml.apiconnector.io.ApiException;
import org.openml.apiconnector.io.HttpConnector;
import org.openml.apiconnector.xml.Data;
import org.openml.apiconnector.xml.Data.DataSet;
import org.openml.apiconnector.xml.DataDelete;
import org.openml.apiconnector.xml.DataFeature;
import org.openml.apiconnector.xml.DataQuality;
Expand All @@ -61,11 +65,10 @@
import org.openml.apiconnector.xml.DataTag;
import org.openml.apiconnector.xml.DataUntag;
import org.openml.apiconnector.xml.TaskDelete;
import org.openml.apiconnector.xml.TaskTag;
import org.openml.apiconnector.xml.TaskUntag;
import org.openml.apiconnector.xml.TaskInputs;
import org.openml.apiconnector.xml.Data.DataSet;
import org.openml.apiconnector.xml.TaskInputs.Input;
import org.openml.apiconnector.xml.TaskTag;
import org.openml.apiconnector.xml.TaskUntag;
import org.w3c.dom.Document;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
Expand All @@ -76,6 +79,7 @@
public class TestDataFunctionality extends BaseTestFramework {
public static final String data_file = "data/iris.arff";
private static final int probe = 61;
private static final int probe_ignore_attribute = 44;
private static final String tag = "junittest";

@Ignore // while working on MinIo, the dataset layout might change slightly. hard to check
Expand Down Expand Up @@ -105,13 +109,19 @@ public void testApiDataDownload() throws Exception {
System.out.println(dsdFromConnector);
}

assertTrue(dsdFromOpenml.equals(dsdFromConnector));
assertEquals(dsdFromOpenml, dsdFromConnector);

// very easy checks, should all pass
assertTrue(dsd.getId() == probe);
assertTrue(features.getFeatures().length > 0);
assertTrue(qualities.getQualities().length > 0);
}

@Test
public void testIgnoreAttributeNotEmpty() throws Exception {
DataSetDescription dsd = client_read_test.dataGet(probe_ignore_attribute);
assertTrue(dsd.getIgnore_attribute().length > 0);
}

@Test
public void testApiDataUnprocessed() throws Exception {
Expand Down