Update Definition of Transmission Delay #481
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luomai 辛苦老师有空的时候帮忙 review 一下 😃 ~ |
|
感谢。我们很快会发布英文版。也欢迎你提交commits！ |
luomai
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原文 ( https://openmlsys.github.io/chapter_distributed_training/collective.html#id3 ) 对 Transmission Delay 的定义有误 . 正确的应该是$b \times l$ 才代表 Transmission Delay， $b$ 只代表传输一个字节所需的时间，即把一个字节从主机传输到传输介质所花的时间，这个时间取决于通信网络的带宽
related issue : #480