Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: make callbacks consistent #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 8, 2024
Merged

refactor: make callbacks consistent #623

merged 4 commits into from
Nov 8, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 8, 2024

Minor change but 2 things were annoying me:

  • The 2 callbacks were passed a different path (relative vs absolute)
  • Some "work" was being done in the predicate function in createServerBundle.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c78455e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 8, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@623

commit: c78455e

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.47% 1650 / 7342
🔵 Statements 22.47% 1650 / 7342
🔵 Functions 56.32% 98 / 174
🔵 Branches 70.57% 415 / 588
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/createAssets.ts 0% 0% 0% 0% 1-241
packages/open-next/src/build/createServerBundle.ts 0% 0% 0% 0% 1-317
packages/open-next/src/build/helper.ts 0% 0% 0% 0% 1-356
Generated in workflow #722 for commit c78455e by the Vitest Coverage Report Action

conico974
conico974 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a small comment, not mandatory at all
Other than that LGTM

@vicb
Copy link
Contributor Author

vicb commented Nov 8, 2024

PTAL

conico974
conico974 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect Thanks

@vicb vicb merged commit 6e53019 into main Nov 8, 2024
3 checks passed
@vicb vicb deleted the traverse branch November 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @conico974