fix 304 incorrectly set as 200 #632
Conversation
🦋 Changeset detectedLatest commit: 2ecb6ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
What about your comment on the issue:
Yeah unfortunately the way next does thing cause a race condition. There is no good way to do this.
The fix works well with streaming wrapper, but not with non streaming one because by the time the request is done and ready to be sent, next has already reset it.
And not applying the status code Next sets will cause the initial issue in Next appear again.
I'll try to open an issue in the Next repo when I got some time, the fix should be done upstream.
Would there be a way to add test?
Not with our current setup, as i said in a previous comment in the issue, this does not happen with the default cloudfront policy (which is what we use). |
Co-authored-by: Victor Berchet <[email protected]>
|
@vicb unless there is something you'd want changed, i'm gonna merge this one and make a release |
|
Great, thanks! |
Fix #631