Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: dummy override errors #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: dummy override errors #650

merged 1 commit into from
Nov 26, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 26, 2024

No description provided.

Copy link

changeset-bot bot commented Nov 26, 2024

🦋 Changeset detected

Latest commit: e9d916a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb requested a review from conico974 November 26, 2024 10:14
Copy link

pkg-pr-new bot commented Nov 26, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@650

commit: e9d916a

Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.73% 1723 / 7577
🔵 Statements 22.73% 1723 / 7577
🔵 Functions 55.73% 102 / 183
🔵 Branches 70.73% 435 / 615
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/overrides/incrementalCache/dummy.ts 0% 0% 0% 0% 1-17
packages/open-next/src/overrides/proxyExternalRequest/dummy.ts 0% 0% 0% 0% 1-11
packages/open-next/src/overrides/queue/dummy.ts 0% 0% 0% 0% 1-11
packages/open-next/src/overrides/warmer/dummy.ts 0% 0% 0% 0% 1-11
Generated in workflow #785 for commit e9d916a by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb
Copy link
Contributor Author

vicb commented Nov 26, 2024

Thanks for the review!

@vicb vicb merged commit ef1fe48 into main Nov 26, 2024
3 checks passed
@vicb vicb deleted the cache-dummy branch November 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants