Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: remove dead code and reorganize binary.ts #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2024
Merged

refactor: remove dead code and reorganize binary.ts #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf11a92
remove binary.ts in utils
sommeeeer Nov 26, 2024
ee9367c
remove binary.ts in adapters
sommeeeer Nov 26, 2024
aa6c3d7
add binary.ts to utils in open-next package
sommeeeer Nov 26, 2024
9d09a49
biome
sommeeeer Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/open-next/src/adapters/cache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { isBinaryContentType } from "./binary";
import { isBinaryContentType } from "../utils/binary";
import { debug, error, warn } from "./logger";

interface CachedFetchValue {
Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/build/createAssets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import fs from "node:fs";
import path from "node:path";

import { isBinaryContentType } from "../adapters/binary.js";
import logger from "../logger.js";
import { isBinaryContentType } from "../utils/binary.js";
import * as buildHelper from "./helper.js";

export function createStaticAssets(options: buildHelper.BuildOptions) {
Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/core/routing/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import { parseHeaders } from "http/util.js";
import type { MiddlewareManifest } from "types/next-types";
import type { InternalEvent, InternalResult } from "types/open-next.js";

import { isBinaryContentType } from "../../adapters/binary.js";
import { debug, error } from "../../adapters/logger.js";
import { isBinaryContentType } from "../../utils/binary.js";

/**
*
Expand Down
2 changes: 1 addition & 1 deletion packages/open-next/src/overrides/proxyExternalRequest/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { request } from "node:https";
import { Readable } from "node:stream";
import type { InternalEvent, InternalResult } from "types/open-next";
import type { ProxyExternalRequest } from "types/overrides";
import { isBinaryContentType } from "../../adapters/binary";
import { isBinaryContentType } from "../../utils/binary";

function filterHeadersForProxy(
headers: Record<string, string | string[] | undefined>,
Expand Down
0 packages/open-next/src/adapters/binary.ts → packages/open-next/src/utils/binary.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion packages/tests-unit/tests/binary.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { isBinaryContentType } from "@opennextjs/aws/adapters/binary.js";
import { isBinaryContentType } from "@opennextjs/aws/utils/binary.js";

describe("isBinaryContentType", () => {
const tests = [
Expand Down
66 changes: 0 additions & 66 deletions packages/utils/src/binary.ts
View file
Open in desktop

This file was deleted.

Loading