Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add: e2e for api routes in pages router #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2025
Merged

add: e2e for api routes in pages router #764

merged 3 commits into from
Mar 3, 2025

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Mar 3, 2025 •
edited
Loading

For #763, add e2e for API routes in pagesRouter example app:

  • Hello world in /api/hello.ts
  • Dynamic API route in /api/dynamic/[slug].ts
  • Catch all route in /api/dynamic/catch-all/[...slug].ts
  • Catch all optional route in /api/dynamic/catch-all-optional/[[...slug]].ts

vicb
vicb reviewed Mar 3, 2025
View reviewed changes
vicb
vicb approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏
Would be nice to have the next bug ID before merging

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c3fbfd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

conico974
conico974 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for that

@conico974 conico974 merged commit 972287e into opennextjs:main Mar 3, 2025
1 check passed
@sommeeeer sommeeeer deleted the add-pages-e2e branch March 4, 2025 07:32
@vicb vicb mentioned this pull request Mar 4, 2025
Closed
@conico974 conico974 mentioned this pull request Mar 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sommeeeer @vicb @conico974