-
Notifications
You must be signed in to change notification settings - Fork 155
Fix rewrite query not forwarded and api destination #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
π¦ Changeset detectedLatest commit: 460ccc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Absolutely, I'll patch my test link in an hour or two - Will update here when done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! SHIP IT after @nicholas-c confirms the fix.
cc: @sommeeeer |
@khuezy page router already has some i18n config. |
yeah, most definitely. we have discussed having some sort of logic that builds different next apps with different configurations (basePath, i18n etc) and then tests them in a Github Action locally. without deploying the actual apps. since most of it can probably be tested that way, and dont really need a deploy. perhaps, until we have that up and going, perhaps we should consider adding an app with some |
@conico974 working perfectly π API route working: i18n config working: Thanks again! |
This PR fix #766
They were 2 different issues described there:
locale
is not set to false, next will always transform in rewrite with an appended locale, but it expects the api route to be not locale prefixed)@nicholas-c Could you confirm that it fixes your issue