Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: move cache assets instead of copying them #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix: move cache assets instead of copying them #883

merged 2 commits into from
Jun 18, 2025

Conversation

makepanic
Copy link
Contributor

@makepanic makepanic commented May 28, 2025 •
edited
Loading

fixes parts of #822

I'm not sure if this is the right approach though, as it mutates the .next directory by moving files from there directly to the .open-next dir.

From a application with tons of static cache files i get the following difference:

  • current version:
    • .next: 2.8 GiB (2,981,986,740 bytes)
    • .open-next: 1.7 GiB (1,876,966,777 bytes)
  • with this change
    • .next: 1.6 GiB (1,687,644,131 bytes)
    • .open-next: 1.7 GiB (1,869,770,983 bytes)

But seeing that the .open-next dir is a bit smaller something might've broken. Running the app with open-next locally worked just fine though

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: be89859

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

conico974
conico974 reviewed May 28, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but i don't think that's what we want to do.
We rely on a bunch of things from the .next folder itself and moving things from there will lead to something that break.
And this will also break some people's deployment, not something we'd want either.

What we should do here instead of copying the file, is to just use the files from .next to compute the cache files instead of copying them. This won't reduce the final size that much, but it will reduce the size used during the deployment itself.

@makepanic
Copy link
Contributor Author

Thanks for the PR, but i don't think that's what we want to do. We rely on a bunch of things from the .next folder itself and moving things from there will lead to something that break. And this will also break some people's deployment, not something we'd want either.

What we should do here instead of copying the file, is to just use the files from .next to compute the cache files instead of copying them. This won't reduce the final size that much, but it will reduce the size used during the deployment itself.

Thanks that makes much more sense. I've attempted to refactor it so it's not copying the output and just works on the next output instead.
I've used it inside my next app and it seems to work just fine. Issue is I can't really compare the output with/without this patch as the next asset generation doesn't seem to be deterministic and size varies by a couple kb every build.
The metaFiles size stays the same tho.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 13, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@883

commit: be89859

conico974
conico974 approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks.
Sorry for such a long delay.

@conico974 conico974 merged commit 6222301 into opennextjs:main Jun 18, 2025
3 checks passed
This was referenced Jun 18, 2025
Merged
Open
@Antoine4011 Antoine4011 mentioned this pull request Jun 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makepanic @conico974