Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: cookie decoding for Node and Cloudflare #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

fix: cookie decoding for Node and Cloudflare #889

merged 4 commits into from
Jun 3, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 2, 2025 •
edited
Loading

fixes #888

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: b2464a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 2, 2025 •
edited
Loading

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@889

commit: b2464a7

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.59% 2567 / 9654
🔵 Statements 26.59% 2567 / 9654
🔵 Functions 53.54% 136 / 254
🔵 Branches 73.2% 612 / 836
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/http/openNextResponse.ts 1.48% 0% 0% 1.48% 20-393
packages/open-next/src/http/util.ts 80% 76.47% 100% 80% 8-9, 13-14, 25-29, 65
packages/open-next/src/overrides/converters/aws-apigw-v2.ts 91.45% 83.33% 100% 91.45% 45-46, 50-54, 114-116
packages/open-next/src/overrides/converters/aws-cloudfront.ts 78.68% 80.76% 100% 78.68% 110-113, 160-200
packages/open-next/src/overrides/converters/edge.ts 0% 0% 0% 0% 1-108
packages/open-next/src/overrides/converters/node.ts 92.45% 71.42% 66.66% 92.45% 56-59
Generated in workflow #1294 for commit b2464a7 by the Vitest Coverage Report Action

@vicb vicb requested a review from khuezy June 2, 2025 17:17
@vicb
Copy link
Contributor Author

vicb commented Jun 2, 2025

/cc @sommeeeer

sommeeeer
sommeeeer reviewed Jun 2, 2025
View reviewed changes
vicb
vicb commented Jun 2, 2025
View reviewed changes
vicb
vicb commented Jun 2, 2025
View reviewed changes
@vicb vicb requested a review from conico974 June 2, 2025 17:32
@sommeeeer
Copy link
Contributor

LGTM

Thanks for doing this. We can consider adding an unit test for the edge converter at a later time.

@vicb
Copy link
Contributor Author

vicb commented Jun 2, 2025

Thanks for doing this. We can consider adding an unit test for the edge converter at a later time.

I'll look into adding an e2e...
(there were unit tests for the Node impl)

khuezy
khuezy reviewed Jun 2, 2025
View reviewed changes
khuezy
khuezy approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

conico974
conico974 approved these changes Jun 3, 2025
View reviewed changes
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit caa57b3 into main Jun 3, 2025
3 checks passed
@vicb vicb deleted the vicb/cookie branch June 3, 2025 07:47
@vicb
Copy link
Contributor Author

vicb commented Jun 3, 2025

Thanks for the reviews!

This was referenced Jun 3, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sommeeeer sommeeeer sommeeeer left review comments

@khuezy khuezy khuezy approved these changes

@conico974 conico974 conico974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Cookies matcher doesn't work properly (cookies wrongly parsed it seems)
4 participants
@vicb @sommeeeer @khuezy @conico974