Thanks to visit codestin.com
Credit goes to github.com

Skip to content

enable e2e/app-router tests to run in CI #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2025
Merged

enable e2e/app-router tests to run in CI #314

merged 3 commits into from
Jan 31, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Jan 31, 2025 •
edited
Loading

this change renames the e2e-fix script of the e2e/app-router app to just e2e so that it is included as part of our CI checks, in order for it not to fail some tests have been skipped (with appropriate comments explain why)

__

Part of #291

@dario-piotrowicz
enable e2e/app-router tests to run in CI
880403b 
this change renames the `e2e-fix` script of the `e2e/app-router` app
to just `e2e` so that it is included as part of our CI checks, in
order for it not to fail some tests have been skipped (with appropriate
comments explain why)
@dario-piotrowicz dario-piotrowicz requested a review from vicb January 31, 2025 12:25
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b225f82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 31, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@314

commit: b225f82

@dario-piotrowicz dario-piotrowicz force-pushed the dario/app-router/e2e-fix branch from 3f10818 to a2d611c Compare January 31, 2025 12:35
vicb
vicb reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like not much is failing outside of what I expected (linked to ISR not implemented).

vicb
vicb approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops looks like I forgot to approve...

@dario-piotrowicz dario-piotrowicz merged commit e939d9f into main Jan 31, 2025
7 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/app-router/e2e-fix branch January 31, 2025 14:04
@dario-piotrowicz dario-piotrowicz mentioned this pull request Feb 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dario-piotrowicz @vicb