fix(preview): Ensure the protocol is correct in redirects from server actions during preview mode #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad79fcb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vicb
reviewed
Jun 2, 2025
commit: |
In theory that shouldn't be a problem. |
vicb
reviewed
Jun 2, 2025
vicb
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686.
Important to note this didn't only affect
next-auth. All redirects from server actions was affected in preview mode.wrangler devwould hang and give an error as it would try to send a request tohttps.Through my research I figured out that Next internally uses
process.env.__NEXT_PRIVATE_ORIGINin standalone mode. They set it duringstartServeron this line. To align with this behavior in preview mode this should be set to the origin during the initialization.Affected lines in Next:
protowould always behttpshere, thus thefetchbelow would recieve the wrong protocol in itsfetchUrl.