test: loose some assertions for fallback: true e2e tests to allow nonbreaking next@canary changes #2976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… breaking next@canary changes
pieh
commented
Jun 25, 2025
Comment on lines
+160
to
+162
| if (!fallbackWasServed) { | ||
| expect(headers1['netlify-cache-tag']).toBe(`_n_t_${encodeURI(pagePath).toLowerCase()}`) | ||
| } |
There was a problem hiding this comment.
fallback does get cache tag with newest canary, but as long as it's not cacheable, we don't actually care about cache tag
Just note that same change is applied 3 times in this PR for variants of the similar test/fixture, but will just comment on first case
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Jun 25, 2025
Comment on lines
+166
to
+168
| nextVersionSatisfies('>=15.4.0-canary.95') | ||
| ? `private, no-cache, no-store, max-age=0, must-revalidate, durable` | ||
| : undefined |
There was a problem hiding this comment.
Both of those mean "no-cache" in practice so those are generally the same in fact that fallback should not be cached
Just note that same change is applied 3 times in this PR for variants of the similar test/fixture, but will just comment on first case
eduardoboucas
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #2974 that adjust assertions for currently failing tests now that
fallback: truecache-control was fixed in vercel/next.js#80865