Fix ad request muted state #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ad request ignores if the player is in muted state, accounting only if the player can autostart with audio. This will cause policy violations, because the ad request will not reflect the real audibility of the ad placement. This fix addresses the problem, by taking into account the actual muted state of the player.
|
thank you @rafa8626 |
|
@vs-gianni I’ll release the new version later tonight. If you haven’t star the project, could you give it a star to show your support please? |
|
Sure, it's a great project: thank you for your commitment! |
|
@vs-gianni I had some urgent thing for work, so I’ll try to publish the version tomorrow first thing |
|
Thank you for the update @rafa8626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ad request currently ignores if the player is in muted state, accounting only if the player can autostart with audio.
This will cause policy violations, because the ad request does not reflect the real audibility of the ad placement.
This fix addresses the problem, by taking into account the actual muted state of the player.