-
Notifications
You must be signed in to change notification settings - Fork 97
Cabview controls for generic items #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Csantucci
merged 2 commits into
openrails:master
from
Csantucci:generic-controls-official
Dec 14, 2021
Merged
Cabview controls for generic items #544
Csantucci
merged 2 commits into
openrails:master
from
Csantucci:generic-controls-official
Dec 14, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Dec 10, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items
twpol
pushed a commit
that referenced
this pull request
Dec 10, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 265b635: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 11, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 564ae46: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 12, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at c457f11: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 12, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #538 at 57e5143: Delete binary paths if the ascii version or the tdb was modified. Blueprint: https://blueprints.launchpad.net/or/+spec/binary-timetable-paths - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 12, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 884b139: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 12, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 12, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 23dfa3f: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 1b818ae: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 13, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at 23dfa3f: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 13, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at e26a9b4: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 13, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at a74d7b8: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 8117250: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage
twpol
pushed a commit
that referenced
this pull request
Dec 14, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at a74d7b8: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 6bf8ab2: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage
pzgulyas
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be a fairly trivial addition, no errors expected here.
twpol
pushed a commit
that referenced
this pull request
Dec 14, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures - Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters - Pull request #531 at b2affac: Bug fix for https://bugs.launchpad.net/or/+bug/1950578 Dyn Brake setup state not disappearing in cab - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #537 at e753905: C# signal script extensions - Pull request #541 at f49e9de: Initial Virtual File System development - Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs - Pull request #543 at 5b0121c: adds Discover > Roadmap webpage - Pull request #544 at 6bf8ab2: Blueprint https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items - Pull request #545 at 32b8d28: Fix VRAM usage
Thank you again for approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: http://www.elvastower.com/forums/index.php?/topic/35572-cabview-controls-for-generic-items/
Blueprint: https://blueprints.launchpad.net/or/+spec/cabview-controls-for-generic-items