-
Notifications
You must be signed in to change notification settings - Fork 97
Fix wrong variable used in battery button #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpol
pushed a commit
that referenced
this pull request
Jan 23, 2022
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #545 at 3f57012: Fix VRAM usage - Pull request #553 at 12e53b1: ScriptManager migration to the CodeAnalysis class. This is in preparation for the net 6 migration. - Pull request #560 at 666e94f: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #564 at af9e9ae: Added TCS parameters file path in consist files (+ refactoring and code cleanup) - Pull request #565 at ebcd9e8: Correct Steam locomoti starting tractive effort. - Pull request #571 at f81fe9f: 01: Manual entries for Menu > Options corrected - Pull request #572 at 7ad5a93: docs: Improved clarity of making changes requirements - Pull request #573 at 6ff61f5: Fix wrong variable used in battery button
Sharpe49
approved these changes
Jan 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops... that's right.
twpol
pushed a commit
that referenced
this pull request
Jan 24, 2022
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #545 at 3f57012: Fix VRAM usage - Pull request #553 at 12e53b1: ScriptManager migration to the CodeAnalysis class. This is in preparation for the net 6 migration. - Pull request #560 at 666e94f: https://blueprints.launchpad.net/or/+spec/label-for-cab-controls , by Jindrich - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #564 at af9e9ae: Added TCS parameters file path in consist files (+ refactoring and code cleanup) - Pull request #571 at f81fe9f: 01: Manual entries for Menu > Options corrected - Pull request #572 at 7ad5a93: docs: Improved clarity of making changes requirements - Pull request #573 at 6ff61f5: Fix wrong variable used in battery button - Pull request #575 at a712a69: Correct information in manual
twpol
pushed a commit
that referenced
this pull request
Jan 24, 2022
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #545 at 3f57012: Fix VRAM usage - Pull request #553 at 12e53b1: ScriptManager migration to the CodeAnalysis class. This is in preparation for the net 6 migration. - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #564 at af9e9ae: Added TCS parameters file path in consist files (+ refactoring and code cleanup) - Pull request #571 at f81fe9f: 01: Manual entries for Menu > Options corrected - Pull request #572 at 7ad5a93: docs: Improved clarity of making changes requirements - Pull request #573 at 6ff61f5: Fix wrong variable used in battery button - Pull request #575 at a712a69: Correct information in manual - Pull request #576 at 867233d: DaylightOffsetHrs control: Fix for offset not effective soon after midnight
twpol
pushed a commit
that referenced
this pull request
Jan 26, 2022
- Pull request #525 at 614b222: TCS extensions - Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 ) - Pull request #545 at 3f57012: Fix VRAM usage - Pull request #553 at 12e53b1: ScriptManager migration to the CodeAnalysis class. This is in preparation for the net 6 migration. - Pull request #561 at 36dcd19: Manual call-on is reset when passing an advanced signal - https://bugs.launchpad.net/or/+bug/1955907 - Pull request #562 at 44f35b4: Remove the locomotive handle from the script, because no interface function can allow access to any internal structure. - Pull request #564 at af9e9ae: Added TCS parameters file path in consist files (+ refactoring and code cleanup) - Pull request #571 at f81fe9f: 01: Manual entries for Menu > Options corrected - Pull request #572 at 7ad5a93: docs: Improved clarity of making changes requirements - Pull request #573 at 6ff61f5: Fix wrong variable used in battery button - Pull request #575 at a712a69: Correct information in manual - Pull request #576 at 867233d: DaylightOffsetHrs control: Fix for offset not effective soon after midnight - Pull request #577 at 92d0926: Bug fix for https://bugs.launchpad.net/or/+bug/1959081 Webserver HUD has misaligned tabs
Csantucci
added a commit
to Csantucci/openrails
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CommandButtonOn variable was incorrectly used for both battery open and battery close buttons