OpenRailway Map #749

sweiland-openrails · 2022-11-19T18:35:41Z

see http://www.elvastower.com/forums/index.php?/topic/36711-openrailway-map-added-to-open-rail-web-interface/

For the Open Rail - Web Interface I've added a Map entry. It shows an OpenRailway map with a locomotive icon on the current position of the train. Of course only useful for simulation of real railways. I use an extra monitor for displaying this map.

I've tested this for the Bernina Pass, the BNSF Scenic SUB and the Edingburgh - Glasgow route. When zooming in the position of the train is not always 100% accurate, but at least it gives you a nice idea where you are and heading for in the real world. The idea is from Flightgear, an open source flight simulator.

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at 0858c49: OpenRailway Map

cjakeman · 2022-11-20T18:59:15Z

Source/RunActivity/Viewer3D/WebServices/Web/Map/index.js

+            if (responseText.length > 0) {
+                latLong = responseText.split(" ");
+                if (typeof locomotivMarker !== 'undefined') {
+                    if ((latLong[0] != latLongPrev[0]) && (latLong[1] != latLongPrev[1])) {


Should this not be || instead of && ?

yes, you are right. Fixed.

sweiland-openrails · 2022-11-20T19:16:13Z

Should I have created the pull request against the unstable branch instead of the master branch?

cjakeman

Hi Siebren,

I tried your map using Demo Model 1 at Edinburgh. The map moves smoothly, but the loco icon stays at the centre but jitters. I guess that's because it moves with the map and then gets re-instated at the centre.

If there's no official way to avoid that, I guess we could use HTML to position the icon overlaid on top of the map and not use .addTo(map) at all.

You've used the recommended 500ms period - good. I didn't find any advantage in using a shorter period.

Thanks for using JsonParse as the other WebApis also do. I would prefer that an object was sent which is parsed by Json.Parse, rather than a string which needs parsing using .split(" "). I can see that the map library needs a string array, so maybe that's the object that should be passed.

Rather than calculate the Lat and Lon in the Web API, could we give the TrainCar class the ability to calculate its own Lat and Lon? Then the Web API becomes merely:

public LatLon LatLon() => Viewer.Simulator.PlayerLocomotive.GetLatLon();

and later on we can use .GetLatLon() for any locomotive.
I was surprised to find that there is no LatLon class in Open Rails. I would add one and append it to the "Orts.Simulation\Common\WorldLatLon.cs".

I may have found a bug (see comments in the index.js code)

Could we have "locomotive" instead of "locomotiv"?
Also "LatLon" instead of "LatLong" (because "LatLon" is already used elsewhere in Open Rails)?

Hope that's helpful and look forward to your thoughts.

Best wishes,

Chris

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at a086ac7: OpenRailway Map

sweiland-openrails · 2022-11-21T12:47:39Z

hi Chris, regarding the jitter you see. I've created a movie how I see it in the browser. Do you see it differently? regards, Siebren OR_ Map - Google Chrome 2022-11-21 12-12-21.mp4 <https://drive.google.com/file/d/1QGQHHZ3Hj6Pkb9VnaaZcD8-tVrRkro09/view?usp=drive_web> Op zo 20 nov. 2022 om 20:27 schreef Chris Jakeman ***@***.***

…

: ***@***.**** commented on this pull request. Hi Siebren, I tried your map using Demo Model 1 at Edinburgh. The map moves smoothly, but the loco icon stays at the centre but jitters. I guess that's because it moves with the map and then gets re-instated at the centre. If there's no official way to avoid that, I guess we could use HTML to position the icon overlaid on top of the map and not use .addTo(map) at all. You've used the recommended 500ms period - good. I didn't find any advantage in using a shorter period. Thanks for using JsonParse as the other WebApis also do. I would prefer that an object was sent which is parsed by Json.Parse, rather than a string which needs parsing using .split(" "). I can see that the map library needs a string array, so maybe that's the object that should be passed. Rather than calculate the Lat and Lon in the Web API, could we give the TrainCar class the ability to calculate its own Lat and Lon? Then the Web API becomes merely: public LatLon LatLon() => Viewer.Simulator.PlayerLocomotive.GetLatLon(); and later on we can use .GetLatLon() for any locomotive. I was surprised to find that there is no LatLon class in Open Rails. I would add one and append it to the "Orts.Simulation\Common\WorldLatLon.cs". I may have found a bug (see comments in the index.js code) Could we have "locomotive" instead of "locomotiv"? Also "LatLon" instead of "LatLong" (because "LatLon" is already used elsewhere in Open Rails)? Hope that's helpful and look forward to your thoughts. Best wishes, Chris — Reply to this email directly, view it on GitHub <#749 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A4HHNDLXXRQQ7SXBYMXFVITWJJ3TDANCNFSM6AAAAAASFOB3KI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

…s/openrails into map_in_browser

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at 2220414: OpenRailway Map

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at 7dab270: OpenRailway Map

cjakeman · 2022-11-21T17:26:46Z

Should I have created the pull request against the unstable branch instead of the master branch?

No, you did the right thing.

The Unstable Branch is populated by a script that runs every 15 mins and looks for suitable PRs from which to build a new Unstable version. It uses all PRs that are not in "Draft" and (have the label "for-unstable" or are submitted by a trusted developer) and do not conflict with any other PRs.

The resulting executables are available as a Zip archive from James' website.

Once approved and merged into the Master branch, this is published as a Testing Version on Friday evenings so the changes can be tried out more widely.

cjakeman · 2022-11-21T19:25:08Z

hi Chris, regarding the jitter you see. I've created a movie how I see it in the browser. Do you see it differently?

Hi Siebren,

Thanks for the video.

No, I see the same behaviour. Not a show-stopper, but would be nice to find a solution.

Best wishes,

Chris

…d index.js. Returned LatLon object for /API/MAP.

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map

ghost · 2022-11-22T13:54:55Z

hi Chris,

for now this is the last commit. I think I've followed all your recommendations.

Except for the jitter. I tried with an interval of 50ms and even 10ms. Makes not such a big difference. Except CPU usage for the browser, which is unacceptable high for 10 ms interval. I also changed for the locomotive marker the delete/create into an update. No change in the jitter. But better coding this way in index.js anyway.

regards, Siebren.

cjakeman · 2022-11-22T19:47:39Z

for now this is the last commit. I think I've followed all your recommendations.

That's great, thanks.

I'll be free to have a look on Thursday.

It's usual to leave a PR in the Unstable Version for a couple of weeks before approving it and merging it into the master branch (i.e. Testing Version).

Best wishes,

Chris

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #713 at 6ca89da: https://blueprints.launchpad.net/or/+spec/cruise-control - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #717 at 44fa8ad: Allow unlimited number of TCS cabview controls - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #733 at 72947b0: Fixed battery switch sound being repeted - Pull request #734 at 8f8484c: Fixed battery switch timer not working properly - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #741 at 2dd56ad: Fixed brake controller script not being loaded in timetable mode - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.

cjakeman · 2022-11-24T09:24:40Z

Hi Siebren,

I'll be free to have a look on Thursday.

It's usual to leave a PR in the Unstable Version for a couple of weeks before approving it and merging it into the master branch (i.e. Testing Version).

Looks very good. Thanks.

I'll post a message on the forum to get some feedback.

Chris

- Pull request #652 at 918fdb1: Add button functions to Raildriver - Pull request #706 at 570ab21: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at 9cffa6d: Improvements for air brakes - Pull request #735 at 3f1bc8c: Added new parameter for battery switch - Pull request #740 at b3e66ca: Refactored the circuit breaker and the traction cut-off relay in order to use the same design pattern as the C# signal scripts (compatible with current scripts) - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 0857d9b: Website release 1.5 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #750 at 424de68: Bug fix for https://bugs.launchpad.net/or/+bug/1997482. Explore in Activity Mode, is not restored.

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at 4609acb: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #756 at c3f5c55: Bug fix for https://bugs.launchpad.net/or/+bug/1999253 Night .dds textures not loaded

cjakeman

Hi Siebren,

All looks good.

Approved with thanks and merged,

Chris

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at ed72cdb: Steam wheel slip#1

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at a63643a: Steam wheel slip#1

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 5c6dbc7: Steam wheel slip#1

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1

sweiland-openrails · 2023-01-02T10:55:22Z

hi Chris,
for my understanding, what is the result of this merging? According to https://github.com/openrails/openrails/blob/6cf0e64619bf6b8735a66274ae4a19fc6fb0784d/Docs/Contributing.md this merging would make the change available in Testing. However after downloading the Testing Version of 30 december I do not find the Map entry on the OR website. Neither in the directory C:\OpenRails-Testing\Content\Web. What has gone wrong or am I misunderstanding this process? Or has it to do with the below "Some checks haven’t completed yet"?
regards, Siebren.

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1 - Pull request #759 at 5ab8faa: fix: Improve sky dome distortion causing bug #1471416

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1 - Pull request #759 at 5ab8faa: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 906e402: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 3c2dc07: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 1b56aa6: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 1b56aa6: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at da4c88e: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #744 at 1b56aa6: Fixed and improved cabview control conditions related to power supply state - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at 3c84439: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #759 at 3c84439: fix: Improve sky dome distortion causing bug #1471416 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 746bdee: build: Remove use of SolutionDir which is not supported everywhere

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 746bdee: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 746bdee: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416 - Pull request #765 at 083467b: Bug fix for https://bugs.launchpad.net/or/+bug/2002183 OK to proceed sound played wrongly

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at 00005ce: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 12e250d: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416 - Pull request #765 at 083467b: Bug fix for https://bugs.launchpad.net/or/+bug/2002183 OK to proceed sound played wrongly

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at b6acfde: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at b87e473: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 12e250d: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416 - Pull request #765 at 083467b: Bug fix for https://bugs.launchpad.net/or/+bug/2002183 OK to proceed sound played wrongly

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at b87e473: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 12e250d: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416 - Pull request #765 at 083467b: Bug fix for https://bugs.launchpad.net/or/+bug/2002183 OK to proceed sound played wrongly

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at f5566d7: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at b87e473: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 12e250d: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416 - Pull request #765 at 083467b: Bug fix for https://bugs.launchpad.net/or/+bug/2002183 OK to proceed sound played wrongly

- Pull request #706 at 91bcfa2: Extended door functionality - Pull request #719 at 13a1638: Upgraded to MonoGame 3.8.0 (+ small update for other libraries) - Pull request #722 at fb9079e: Fix Windows Forms deprecations in ActivityEditor - Pull request #732 at aac9b67: Improvements for air brakes - Pull request #735 at b9a0ea3: Added new parameter for battery switch - Pull request #746 at f5566d7: Website release 1.5.1 - Pull request #748 at 4f0e878: latitude/longitude fix for bug 1393111 - Pull request #749 at db5764c: OpenRailway Map - Pull request #753 at ab8fe32: Extends CabControls for user input - Pull request #754 at 70a1325: Container weights: https://blueprints.launchpad.net/or/+spec/container-weights - Pull request #758 at ee55d7a: Steam wheel slip#1 - Pull request #760 at 113dd63: Updated EditorConfig with .NET and StyleCop analyzer configuration - Pull request #761 at f6a3aca: fix: Allow 100% cloud-free skys by making 0% overcast = 0% clouds - Pull request #763 at 12e250d: build: Remove use of SolutionDir which is not supported everywhere - Pull request #764 at 5f9a01b: fix: Improve sky dome distortion causing bug #1471416 - Pull request #765 at 083467b: Bug fix for https://bugs.launchpad.net/or/+bug/2002183 OK to proceed sound played wrongly

cjakeman · 2023-01-09T19:56:56Z

Converted to Draft temporarily to see if changing it back will overcome the message "Waiting for status to be reported"

cjakeman · 2023-01-09T20:13:54Z

What has gone wrong or am I misunderstanding this process? Or has it to do with the below "Some checks haven’t completed yet"?

No, you understand the process correctly. It's the message "Some checks haven't completed yet" that indicates a problem. I don't see why it should be a problem and I think I shall have to get help with this from James.

Best wishes,

Chris

sweiland-openrails added 2 commits November 19, 2022 11:14

OpenRailway Map

0858c49

latitude/longitude fix for bug 1393111

4f0e878

cjakeman added enhancement New feature or request for-unstable Special label to include a pull request in the Unstable Version labels Nov 20, 2022

cjakeman reviewed Nov 20, 2022

View reviewed changes

sweiland-openrails and others added 2 commits November 21, 2022 11:09

fixed and (&&) in or (II) in if lat != latPrev

2523f91

Merge branch 'openrails:master' into map_in_browser

a086ac7

Merge branch 'lat_long_fix_bug_1393111' into map_in_browser

e6cc553

sweiland-openrails added 2 commits November 21, 2022 14:24

changed latLong --> latLon, corrected locomotiv --> locomotive

6dce048

Merge branch 'map_in_browser' of https://github.com/sweiland-openrail…

2220414

…s/openrails into map_in_browser

Another && to || fix

7dab270

Created class LatLon. Created function GetLatLon in TrainCar. Reworke…

db5764c

…d index.js. Returned LatLon object for /API/MAP.

cjakeman approved these changes Dec 28, 2022

View reviewed changes

cjakeman marked this pull request as draft January 9, 2023 19:55

cjakeman marked this pull request as ready for review January 9, 2023 20:04

cjakeman merged commit d2e6821 into openrails:master Jan 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OpenRailway Map #749

OpenRailway Map #749

Uh oh!

sweiland-openrails commented Nov 19, 2022

Uh oh!

cjakeman Nov 20, 2022

Uh oh!

sweiland-openrails Nov 20, 2022 •

edited

Loading

Uh oh!

sweiland-openrails commented Nov 20, 2022

Uh oh!

cjakeman left a comment

Uh oh!

sweiland-openrails commented Nov 21, 2022 via email

Uh oh!

cjakeman commented Nov 21, 2022

Uh oh!

cjakeman commented Nov 21, 2022

Uh oh!

ghost commented Nov 22, 2022

Uh oh!

cjakeman commented Nov 22, 2022

Uh oh!

cjakeman commented Nov 24, 2022

Uh oh!

cjakeman left a comment

Uh oh!

sweiland-openrails commented Jan 2, 2023 •

edited

Loading

Uh oh!

cjakeman commented Jan 9, 2023

Uh oh!

cjakeman commented Jan 9, 2023

Uh oh!

Uh oh!

OpenRailway Map #749

OpenRailway Map #749

Uh oh!

Conversation

sweiland-openrails commented Nov 19, 2022

Uh oh!

cjakeman Nov 20, 2022

Choose a reason for hiding this comment

Uh oh!

sweiland-openrails Nov 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sweiland-openrails commented Nov 20, 2022

Uh oh!

cjakeman left a comment

Choose a reason for hiding this comment

Uh oh!

sweiland-openrails commented Nov 21, 2022 via email

Uh oh!

cjakeman commented Nov 21, 2022

Uh oh!

cjakeman commented Nov 21, 2022

Uh oh!

ghost commented Nov 22, 2022

Uh oh!

cjakeman commented Nov 22, 2022

Uh oh!

cjakeman commented Nov 24, 2022

Uh oh!

cjakeman left a comment

Choose a reason for hiding this comment

Uh oh!

sweiland-openrails commented Jan 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjakeman commented Jan 9, 2023

Uh oh!

cjakeman commented Jan 9, 2023

Uh oh!

Uh oh!

sweiland-openrails Nov 20, 2022 •

edited

Loading

sweiland-openrails commented Jan 2, 2023 •

edited

Loading