Removed subject methods Recipe - Added the recipe to the top List#553
Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom Sep 12, 2024
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
timtebeek
approved these changes
Sep 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
The recipe should change doAs() method with callAs() method. The existing recipe was replacing the wrong Value. Now, updated the recipe with correct values. Added the recipe in the top list.
What's your motivation?
I used org.openrewrite.java.ChangeMethodName for the recipe RemovedSubjectMethods.
Anyone you would like to review specifically?
@timtebeek @cjobinabo
Checklist