Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

Conversation

jaellio
Copy link
Contributor

@jaellio jaellio commented Apr 22, 2022

Description:

Adds the CRD for MeshRootCertificate API.

Part of #4502

Affected area:

Functional Area
New Functionality [x]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2022

Codecov Report

Merging #4687 (545c211) into main (bc3ff99) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4687      +/-   ##
==========================================
+ Coverage   69.44%   69.46%   +0.02%     
==========================================
  Files         217      217              
  Lines       15287    15423     +136     
==========================================
+ Hits        10616    10714      +98     
- Misses       4621     4659      +38     
  Partials       50       50              
Flag Coverage Δ
unittests 69.46% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/utils/proto.go 36.00% <0.00%> (-24.00%) ⬇️
pkg/injector/webhook.go 88.37% <0.00%> (-0.04%) ⬇️
pkg/k8s/client.go 93.09% <0.00%> (ø)
pkg/injector/volumes.go 100.00% <0.00%> (ø)
pkg/injector/envoy_config.go 71.79% <0.00%> (+0.07%) ⬆️
pkg/injector/patch.go 75.95% <0.00%> (+2.57%) ⬆️
pkg/cli/verifier/envoy_config.go 67.25% <0.00%> (+2.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3ff99...545c211. Read the comment docs.

jaellio added 2 commits April 22, 2022 16:22
Adds the CRD for MeshRootCertificate API.

Part of openservicemesh#4502

Signed-off-by: jaellio <[email protected]>
Signed-off-by: jaellio <[email protected]>
@jaellio jaellio force-pushed the meshRootCertCRD branch 2 times, most recently from fd9e7d9 to 32c0866 Compare April 23, 2022 00:53
@jaellio jaellio marked this pull request as ready for review April 25, 2022 21:59
@jaellio jaellio merged commit 19eb161 into openservicemesh:main May 2, 2022
@jaellio jaellio linked an issue Jul 7, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define MeshRootCertificate API
4 participants