This repository was archived by the owner on Jul 11, 2023. It is now read-only.
feat(certificate): create a compat layer for provider generation #4718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9f5525 to
6db2bd0
Compare
jaellio
reviewed
May 5, 2022
43a6447 to
09fd7e5
Compare
Codecov Report
@@ Coverage Diff @@
## main #4718 +/- ##
==========================================
- Coverage 69.56% 69.51% -0.06%
==========================================
Files 220 225 +5
Lines 15800 15983 +183
==========================================
+ Hits 10992 11110 +118
- Misses 4758 4822 +64
- Partials 50 51 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jaellio
reviewed
May 11, 2022
b7c55af to
cdc6130
Compare
jaellio
reviewed
May 12, 2022
jaellio
reviewed
May 12, 2022
da0730d to
d6079f9
Compare
nojnhuh
approved these changes
May 12, 2022
jaellio
approved these changes
May 12, 2022
d6079f9 to
397c15b
Compare
|
addressed all comments and squashed to single commit |
The compat layer is used to convert from the old style options to the new style MRC. This is useful so that we don't have to manage to implementations of the certificate.Manager. Signed-off-by: Sean Teeling <[email protected]>
397c15b to
8c3a1e1
Compare
30 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compat layer is used to convert from the old style options
to the new style MRC. This is useful so that we don't have to manage
two implementations of the certificate.Manager.
Signed-off-by: Sean Teeling [email protected]
part of #4713