PSAP-1655: Make machineConfigLabels-related misconfiguration more visible #1316
Conversation
NTO Tuned CRs support machine config labels (mcLabels) based matching. This involves finding a MachineConfigPool with machineConfigSelector matching mcLabels and setting a TuneD profile on all nodes that are assigned the found MachineConfigPool. We do not support configurations, where more than 1 MachineConfigPool matches the mcLabels. While this configuration is not supported, users often unwittingly configure their clusters in this way. In this case, NTO issues an error message in the operator logs. This is often not sufficient, so we make this misconfiguration more visible by making ClusterOperator/node-tuning object Degraded.
|
@jmencak: This pull request references PSAP-1655 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
NTO Tuned CRs support machine config labels (mcLabels) based matching. This involves finding a MachineConfigPool with machineConfigSelector matching mcLabels and setting a TuneD profile on all nodes that are assigned the found MachineConfigPool. We do not support configurations, where more than 1 MachineConfigPool matches the mcLabels. While this configuration is not supported, users often unwittingly configure their clusters in this way. In this case, NTO issues an error message in the operator logs.
This is often not sufficient, so we make this misconfiguration more visible by making ClusterOperator/node-tuning object Degraded.