Fix kube scheduler health/liveness probes #868
Conversation
In 4.10, the scheduler uses a secure port for its healthz endpoint and it changed the default port that it listens on. In this change we specify the secure port and use that same port for liveness and readiness probes.
| fmt.Sprintf("--config=%s", configPath), | ||
| fmt.Sprintf("--cert-dir=%s", certWorkDir), | ||
| "--port=0", | ||
| fmt.Sprintf("--secure-port=%d", schedulerSecurePort), |
There was a problem hiding this comment.
Do we need to keep the old arg to disable the insecure port in versions < 4.10/1.23?
There was a problem hiding this comment.
Upstream removed that flag in 1.23
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah, I was getting a complaint in the log about it, so I decided to get rid of it
There was a problem hiding this comment.
Ok, lets assume that this isn't a security issue for previous versions
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@csrwng: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In 4.10, the scheduler uses a secure port for its healthz endpoint and
it changed the default port that it listens on.
In this change we specify the secure port and use that same port for
liveness and readiness probes.