Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bug 1927263: UPSTREAM: 99336: kubelet: improve the node informer sync check #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2021
Merged

Bug 1927263: UPSTREAM: 99336: kubelet: improve the node informer sync check #704

merged 1 commit into from
Apr 29, 2021

Conversation

ehashman
Copy link

@neolit123 @ehashman
UPSTREAM: 99336: kubelet: improve the node informer sync check
c51dd0e 
GetNode() is called in a lot of places including a hot loop in
fastStatusUpdateOnce. Having a poll in it is delaying
the kubelet /readyz status=200 report.

If a client is available attempt to wait for the sync to happen,
before starting the list watch for pods at the apiserver.
@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Apr 22, 2021
@openshift-ci-robot
Copy link

@ehashman: This pull request references Bugzilla bug 1927263, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 1927263: UPSTREAM: 99336: kubelet: improve the node informer sync check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 22, 2021
@openshift-ci-robot
Copy link

@ehashman: the contents of this pull request could be automatically validated.

The following commits are valid:

@ehashman
Copy link
Author

/test images
/test e2e-gcp-upgrade
/test e2e-aws-serial

@ehashman
Copy link
Author

/retest

@ehashman
Copy link
Author

/cherry-pick release-4.7

@openshift-cherrypick-robot
Copy link

@ehashman: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@praveenkumar
Copy link

/retest

@ehashman
Copy link
Author

/skip

@mrunalp
Copy link
Member

mrunalp commented Apr 27, 2021

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021
@praveenkumar
Copy link

/retest

1 similar comment
@ehashman
Copy link
Author

/retest

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Apr 28, 2021 •
edited
Loading

@ehashman: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-cmd c51dd0e link /test e2e-agnostic-cmd
ci/prow/e2e-aws-csi c51dd0e link /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit daa555a into openshift:master Apr 29, 2021
@openshift-ci-robot
Copy link

@ehashman: All pull requests linked via external trackers have merged:

Bugzilla bug 1927263 has been moved to the MODIFIED state.

In response to this:

Bug 1927263: UPSTREAM: 99336: kubelet: improve the node informer sync check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@ehashman: #704 failed to apply on top of branch "release-4.7":

Applying: UPSTREAM: 99336: kubelet: improve the node informer sync check
Using index info to reconstruct a base tree...
M	pkg/kubelet/config/apiserver.go
M	pkg/kubelet/kubelet.go
M	pkg/kubelet/kubelet_getters.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/kubelet/kubelet_getters.go
Auto-merging pkg/kubelet/kubelet.go
CONFLICT (content): Merge conflict in pkg/kubelet/kubelet.go
Auto-merging pkg/kubelet/config/apiserver.go
CONFLICT (content): Merge conflict in pkg/kubelet/config/apiserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 UPSTREAM: 99336: kubelet: improve the node informer sync check
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman ehashman mentioned this pull request Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@rphillips rphillips Awaiting requested review from rphillips

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ehashman @openshift-ci-robot @openshift-cherrypick-robot @praveenkumar @mrunalp @openshift-bot @openshift-merge-robot @neolit123