Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Python3.7 compatibility: async is a reserved keyword #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Chive opened this issue Jul 17, 2018 · 5 comments · Fixed by #197
Closed

Python3.7 compatibility: async is a reserved keyword #183

Chive opened this issue Jul 17, 2018 · 5 comments · Fixed by #197
Assignees
@fabianvf
Labels
priority: high

Comments

@Chive
Copy link

Chive commented Jul 17, 2018 •
edited
Loading

Hi all,

While trying to import the library with python3.7, the following error occurs:

  File "/virtualenv/lib/python3.7/site-packages/openshift/__init__.py", line 15, in <module>
    import openshift.client
  File "/virtualenv/lib/python3.7/site-packages/openshift/client/__init__.py", line 221, in <module>
    from .apis.apps_openshift_io_api import AppsOpenshiftIoApi
  File "/virtualenv/lib/python3.7/site-packages/openshift/client/apis/__init__.py", line 4, in <module>
    from .apps_openshift_io_api import AppsOpenshiftIoApi
  File "/virtualenv/lib/python3.7/site-packages/openshift/client/apis/apps_openshift_io_api.py", line 120
    async=params.get('async'),
        ^
SyntaxError: invalid syntax

This has already been fixed in the upstream here kubernetes-client/python#568.
@Chive Chive changed the title Python3.7 compatibility Python3.7 compatibility: async is a reserved keyword Jul 17, 2018
@fabianvf
Copy link
Member

I think this will also affect the dynamic implementation. We will need to base this against the not yet released kubernetes python client, so we will need to wait for 7.0 to come out before we can actually ship this.

Also side note for @Chive, we are deprecating the generated openshift modules in favor of a dynamic implementation found in openshift/dynamic/client.py. It still makes use of the kubernetes client but has a generic interface for discovering and interacting with resources.

@fabianvf fabianvf self-assigned this Jul 30, 2018
@pvdvreede
Copy link

7.0.0 came out a day ago, so is this issue able to be actioned now? thanks.

@fabianvf fabianvf mentioned this issue Aug 27, 2018
Merged
@dbazhal
Copy link

dbazhal commented Aug 31, 2018

Tx for fixing this, well done!

@pvdvreede
Copy link

Great! Many thanks for the quick attention to this.

@fabianvf
Copy link
Member

No problem, thanks for bringing it to my attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabianvf fabianvf

Labels
priority: high
Projects
None yet
Milestone
No milestone
4 participants
@pvdvreede @dbazhal @fabianvf @Chive