Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename async to async_req for compatibility with python3 and kubernetes 7 #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2018
Merged

Rename async to async_req for compatibility with python3 and kubernetes 7 #197

merged 6 commits into from
Aug 29, 2018

Conversation

fabianvf
Copy link
Member

@fabianvf fabianvf commented Aug 27, 2018 •
edited
Loading

fixes #183

This PR will break backwards compatibility

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 27, 2018
@fabianvf
Copy link
Member Author

ping @Chive @pvdvreede

@willthames
Copy link
Contributor

These tests appear to be timing out rather than failing. Not sure if they need breaking up or profiling or some travis configuration to allow them to take longer

@yboaron
Copy link

yboaron commented Aug 29, 2018

I'd tested this PR with Kubernetes client 7.0.0 , and it's working!
I'm not getting [1] error anymore.

[1] File "/usr/lib/python2.7/site-packages/openshift/dynamic/client.py", line 58, in init
self._load_server_info()
File "/usr/lib/python2.7/site-packages/openshift/dynamic/client.py", line 62, in _load_server_info
self.__version = {'kubernetes': load_json(self.request('get', '/version'))}
File "/usr/lib/python2.7/site-packages/openshift/dynamic/client.py", line 255, in request
_return_http_data_only=params.get('_return_http_data_only', True)
TypeError: call_api() got an unexpected keyword argument 'async'

@willthames willthames mentioned this pull request Aug 29, 2018
Merged
@willthames
Copy link
Contributor

I've also run the updated ansible k8s test suite from ansible/ansible#44821 and it passes

@fabianvf fabianvf merged commit 1ab119d into openshift:master Aug 29, 2018
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2018
@fabianvf @willthames
Rename async to async_req for compatibility with python3 and kubernet…
ed7fdeb 
…es 7 (openshift#197)

* Rename async to async_req for python3 and kubernetes 7 compatibility

* Update requirements

* Update versions

* update tests

* update tox for 3.9

* fix py3 test issue
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
@fabianvf @willthames
Rename async to async_req for compatibility with python3 and kubernet…
e2eed91 
…es 7 (openshift#197)

* Rename async to async_req for python3 and kubernetes 7 compatibility

* Update requirements

* Update versions

* update tests

* update tox for 3.9

* fix py3 test issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python3.7 compatibility: async is a reserved keyword
4 participants
@fabianvf @willthames @yboaron @openshift-ci-robot