This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[ART-4751] update valid-subscription in csv#643
Merged
Conversation
Build #1 |
Member
There was a problem hiding this comment.
/hold
It was confirmed by @gallettilance that the label should be present in the CSV and not in annotations.yaml. Which is accomplished by this code change. A side-effect of this PR, is that the label will be gone from the Dockerfile as well, is that correct/desired?
Example: https://pkgs.devel.redhat.com/cgit/containers/cluster-nfd-operator-bundle/tree/Dockerfile?h=rhaos-4.11-rhel-8#n23 Last line will be removed if this PR gets merged.
Build #2 |
Build #3 |
Build #4 |
Build #5 |
Contributor
Author
|
confirmed from email, no need for Dockerfile, so the pr is still valid |
Contributor
Author
|
/unhold |
Build #6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #642