Fix deprecations for twig 3#28
Merged
Merged
Conversation
pharv
approved these changes
Mar 8, 2022
Contributor
|
a tag for this release would be helpful I think? Any opposition to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Twig 2.11 then
Twig_Extensionclass was marked as deprecated and replaced with\Twig\Extension\ExtensionInterfacewhich was causing this package to block twig3 to be installed in newer Symfony installations. (5.4 tested).The PR addresses the issue by extending the included new
AbstractExtensionclass, updating the use ofTwigFunctionand removinggetNamewhich was deprecated in Twig 1.26.