Fix non-ASCII characters in external items and external file descriptors #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses bugs related to non-ASCII character handling in external items and file handlers by replacing manual string conversion loops with dedicated helper functions. Key changes include:
- Replacing manual '-' replacement with a call to strcpy_identifier_cobol_to_java.
- Removing in-line conversion loops in external file handler routines.
- Updating external item declarations to use consistent helper functions for identifier conversion.
Files not reviewed (1)
- tests/misc.src/fd-external.at: Language not supported
Comments suppressed due to low confidence (2)
cobj/codegen.c:2255
- [nitpick] Verify that passing 'CB_FILE(file)->record->name' directly produces the correct identifier conversion without the previously used manual loop, especially for non-ASCII characters.
joutput(" = CobolExternal.getStorageAddress ("%s", %d);",
cobj/codegen.c:5581
- [nitpick] Confirm that the combined use of joutput_prefix() and joutput_base(f) fully replicates the intended transformation behavior for external item names, ensuring correct handling of non-ASCII characters.
joutput_prefix();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following bugs related to non-ASCII characters.
－in external items and external file descriptors into another valid character in Java.ＢＣin external file descriptors into invalid characters.Addition of a new test case:
tests/misc.src/fd-external.atto verify the handling of external file descriptors with non-ASCII characters in field names.