Improve full tool result viewer#590
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Scope boundary: WebUI full tool-result rendering, run-trace context propagation, regression tests, six locale files, and the checked-in gateway bundle.
Non-goals: Backend tool-result formats, result retrieval/storage, or a general-purpose file editor.
Branch
Base branch: main
Target exception: N/A
Issue
Linked issue: None
If None, reason: Direct UX improvement requested and validated in the WebUI without a pre-existing issue.
Release Note
Release note: Improve the WebUI full tool-result viewer with file metadata, syntax highlighting, line numbers, wrapping, and copy controls.
Why
The previous drawer rendered every expanded result as a plain pre-wrapped text block. Large file reads and command outputs lost structure, long lines were difficult to inspect, and users had to manually select content to copy it.
Review notes
read_filecalls keep the file path but are displayed as error text instead of being mislabeled from the target extensionTests
Ruff: Not needed (frontend-only change).
Pytest: Not needed (frontend-only change).
Build:
cd opensquilla-webui && npm run buildpassed, including typecheck, architecture/security guards, theme checks, i18n parity, and the production bundle.Regression tests: added
Notes:
cd opensquilla-webui && npm run test:unitpassed — 95 files / 806 tests.The default test path remains offline, deterministic, credential-free, and safe for forks.
Maintainer Live Check
Maintainer live check: no
Surface: gateway
Maintainer-only note: The implementation was visually exercised against the local WebUI; no credentialed live service is required.
Safety
Secrets, local-only artifacts, private prompts/transcripts, channel identifiers, AI session artifacts, non-public fixtures, and
tests/_private/contents are not committed.Third-Party Origin
Third-party origin: none
Details if non-none: N/A. This change uses DOMPurify and highlight.js already present in the project dependencies; no upstream source or fixtures were copied.
Documentation Changes