Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove the ossl_prov_digest_load_from_params() function and clean up arounds its use #28361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove the ossl_prov_digest_load_from_params() function and clean up arounds its use #28361

wants to merge 5 commits into from

Conversation

paulidale
Copy link
Contributor

The function is internal and it is no longer being used. Time for it to disappear.

@paulidale paulidale self-assigned this Aug 28, 2025
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: refactor The issue/pr requests/implements refactoring style: waived exempted from style checks labels Aug 28, 2025
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Aug 28, 2025
beldmit
beldmit approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oqs provider failure is irrelevant. Not sure about the RPKI one.
LGTM otherwise

@paulidale paulidale force-pushed the remove-digest-helper branch from ad48238 to cdf5bb5 Compare August 31, 2025 22:32
@paulidale
Copy link
Contributor Author

rebased without changes to get rid of build error

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 1, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 2, 2025
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks for the approvals.

@paulidale paulidale closed this Sep 3, 2025
@paulidale paulidale deleted the remove-digest-helper branch September 3, 2025 00:27
openssl-machine pushed a commit that referenced this pull request Sep 3, 2025
@paulidale
hkdf: avoid using ossl_prov_digest_load_from_params()
ce3714c 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28361)
openssl-machine pushed a commit that referenced this pull request Sep 3, 2025
@paulidale
pbkdf2: avoid using ossl_prov_digest_load_from_params()
8909838 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28361)
openssl-machine pushed a commit that referenced this pull request Sep 3, 2025
@paulidale
pvkkdf: avoid using ossl_prov_digest_load_from_params()
f316d93 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28361)
openssl-machine pushed a commit that referenced this pull request Sep 3, 2025
@paulidale
kmac: avoid using ossl_prov_digest_load_from_params()
d5efc85 
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28361)
openssl-machine pushed a commit that referenced this pull request Sep 3, 2025
@paulidale
remove ossl_prov_digest_load_from_params()
7a9e0e0 
This is no longer used or needed and is internal, so away it goes.

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from #28361)
@esyr esyr mentioned this pull request Sep 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@t-j-h t-j-h t-j-h approved these changes

@beldmit beldmit beldmit approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources style: waived exempted from style checks triaged: refactor The issue/pr requests/implements refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulidale @openssl-machine @t8m @t-j-h @beldmit