kmac_prov.c.in: avoid resource leak on kmac_new_decoder fail in kmac_fetch_new #28516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1b7b84 to
915eb3d
Compare
paulidale
approved these changes
Sep 10, 2025
915eb3d to
849a14a
Compare
paulidale
previously approved these changes
Sep 10, 2025
|
This needs to go to 3.6 too. |
Does it? The offending commit is not in the [1] https://github.com/openssl/openssl/commits/openssl-3.6/providers/implementations/macs/kmac_prov.c.in |
|
Ah, missed that bit. |
slontis
reviewed
Sep 11, 2025
…fetch_new kctx was not freed in a case of kmac_new_decoder failure; consolidate all the error paths under the "err:" label and jump to it on kmac_new_decoder() returning 0. Fixes: d5efc85 "kmac: avoid using ossl_prov_digest_load_from_params()" Resolves: openssl/project#1419 Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1453634 Signed-off-by: Eugene Syromiatnikov <[email protected]>
849a14a to
80d33f9
Compare
Sashan
approved these changes
Sep 11, 2025
t8m
approved these changes
Sep 11, 2025
paulidale
approved these changes
Sep 11, 2025
|
This pull request is ready to merge |
|
merged to master, thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 12, 2025
…fetch_new kctx was not freed in a case of kmac_new_decoder failure; consolidate all the error paths under the "err:" label and jump to it on kmac_new_decoder() returning 0. Fixes: d5efc85 "kmac: avoid using ossl_prov_digest_load_from_params()" Resolves: openssl/project#1419 Resolves: https://scan5.scan.coverity.com/#/project-view/65248/10222?selectedIssue=1453634 Signed-off-by: Eugene Syromiatnikov <[email protected]> Reviewed-by: Saša Nedvědický <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tom Cosgrove <[email protected]> Reviewed-by: Neil Horman <[email protected]> (Merged from #28516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kctx was not freed in a case of kmac_new_decoder failure; consolidate all the error paths under the "err:" label and jump to it on kmac_new_decoder() returning 0.
Fixes: d5efc85 "kmac: avoid using ossl_prov_digest_load_from_params()"
Resolves: openssl/project#1419