Codestin Search App

vooon · 2025-10-31T14:08:47Z

That is a refactoring to use gophercloud/v2.

Update Go requirement to 1.25
Drop gophercloud v1
Fix Wrong hypervisor vCPUs calculation if node reports multiple NUMA cells #494
Added API discovery reports fixture to most of the services
Add test for Swift
Add build_info metric

Tries to solve some of #500

Sharpz7 · 2025-10-31T21:19:42Z

Wow! Thanks for this @vooon. Really appreciate it

exporters/nova.go

Sharpz7 · 2025-11-04T01:23:51Z

Looks good - I think with a few fixes and a quick change to the heat test fixture, tests should pass.

I think I would feel more comfortable merging this however after merging #481 - just since this is such a large change. I would be interested in your opinion too :)

vooon · 2025-11-10T08:38:21Z

@Sharpz7 sorry, i was on a vacation. I'm unsure if i can fully test things like Heat or Designate, as the stacks i'm currently working on have quite a narrow use.
Of course i can setup devstack, just it'll be far from what i had working on full featured distro (at the same time, i'm glad not:).

Sharpz7 · 2025-11-12T18:41:29Z

@vooon I don't have that either, but the CI is pretty good right now. If you don't mind, I can work on this PR after I get the integration tests working (that sets up a devstack in CI so that we get better tests).

Just let me know if you are okay with me pushing to this branch

vooon · 2025-11-12T19:00:56Z

@Sharpz7 yes, please go ahead. Devstack setup surprisingly takes more time...

Sharpz7 · 2025-11-13T04:50:32Z

Sounds good - might take me a while to get to but hopefully not too long, I think you have done a large chunk of the work already :)

vooon · 2025-11-19T15:11:23Z

@Sharpz7 some updates:

Updated nova hypervisors with the one I got from the devstack (but then i editied values to be the same).
Mainly that was required because of incorrect next page link.
It was a bit unpleasant to find out why the heck gophercloud tries to pull some unrelated url.
Added request logging is OS_DEBUG env set (what helped me to debug trouble above).
Fixed microversion requirement for Nova. Unsure why that worked in fleeting runner... But now, when API responds with multiple versions, and you don't have /v2.1 suffix - it breaks.
That's actually not the case for recent clouds, where you usually has only /v2.1...
Updated gophercloud to 2.9.0 and fixed vCPU counting bug. But that enforced to change Go to 1.24.

vooon · 2025-11-20T14:39:00Z

@Sharpz7 well, i'm complete. Ready for review. Please run also Copilot, interesting if it'll find anything useful.

Sharpz7 · 2025-11-22T02:12:40Z

Hey @vooon ! Thank you so much with this. I am stuck with a lot of academic work right now, but will review soon.

As requested, I will run copilot now

Copilot

Pull request overview

This PR modernizes the openstack-exporter codebase by migrating from gophercloud v1 to v2, a significant refactoring effort. The migration updates the underlying OpenStack SDK library to its latest version, which involves updating import paths, API signatures, and client initialization patterns throughout the codebase. The PR also updates the Go version requirement from 1.23 to 1.24 and includes comprehensive test coverage updates with new fixtures for API discovery endpoints.

Key changes:

Complete migration from github.com/gophercloud/gophercloud v1 to v2 with updated import paths
Introduction of microversion handling utilities for better API version management
Updated all service exporters to use context-aware v2 API calls with context.Context parameter
Refactored status mapping from array-based to map-based for better performance and maintainability

Reviewed changes

Copilot reviewed 42 out of 44 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
go.mod, go.sum	Updated Go version to 1.24 and gophercloud dependencies to v2.9.0
utils/microversion.go	New utility for managing API microversions with environment variable support
exporters/exporter.go	Removed v1 client, added context-aware collection, improved transport configuration
exporters/utils.go	Refactored client creation to v2 API, added generic RemoveElements helper
exporters/nova.go	Added microversion setup, refactored flavor ID mapping, improved CPU topology calculation
exporters/neutron.go	Updated to v2 APIs, improved port fixed IP handling, added identity client helper
exporters/cinder.go	Simplified volume status handling, updated to context-aware v2 calls
exporters/*.go	All service exporters updated to accept context parameter and use v2 client
exporters/fixtures/*	Added API discovery fixtures for most services, updated test data
exporters/*_test.go	Updated test expectations to match v2 API responses
cache/*.go	Updated to use v2 client config, improved test assertions
Dockerfile, .github/workflows/ci.yaml	Updated Go version to 1.24

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vooon · 2025-11-22T09:01:01Z

Hmm, this time Copilot has nice description, not just retelling PR comment :)

@Sharpz7 ok, in a mean time I'm started testing it up on some of clouds.

Sharpz7 · 2025-11-24T03:57:04Z

Yes @vooon! I view this AI stuff as "the worst it will ever be" - I think eventually it will be really helpful!

Meanwhile I'll work on #481

vooon · 2025-12-02T12:54:38Z

@Sharpz7 i've encountered the same bug as in #513 but done some refactoring. Also fixed merge error.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 44 out of 46 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Why: mechanical migration to gophercloud v2 APIs. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: mechanical framework migration to gophercloud v2. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: mechanical signature alignment for gophercloud v2. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: centralize microversion setup during gophercloud v2 porting. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: move ironic microversion setup to the common framework helper. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: prevent project-name collisions (cardinality). Signed-off-by: Vladimir Ermakov <[email protected]>

Why: alert correlation improvement (cardinality). Signed-off-by: Vladimir Ermakov <[email protected]>

Fix openstack-exporter#519 which is proposed in openstack-exporter#520 Co-authored-by: Dejan Sanader <[email protected]> Signed-off-by: Vladimir Ermakov <[email protected]>

Why: improve troubleshooting context for baremetal. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: add operational visibility for node lifecycle. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: expose provider generation for drift diagnostics. Signed-off-by: Vladimir Ermakov <[email protected]>

Why: select available services and fail fast on auth/catalog issues. Signed-off-by: Vladimir Ermakov <[email protected]>

Signed-off-by: Vladimir Ermakov <[email protected]>

Summary: - align README metrics table and CLI flags with current behavior - add exporter build info metric entry Why: Keep documentation in sync with implementation to avoid operator confusion. Signed-off-by: Vladimir Ermakov <[email protected]>

Sharpz7 reviewed Nov 4, 2025

View reviewed changes

exporters/nova.go Outdated Show resolved Hide resolved

vooon marked this pull request as ready for review November 20, 2025 14:33

vooon requested a review from Sharpz7 November 20, 2025 14:39

Sharpz7 requested a review from Copilot November 22, 2025 02:12

Copilot started reviewing on behalf of Sharpz7 November 22, 2025 02:13 View session

Copilot finished reviewing on behalf of Sharpz7 November 22, 2025 02:13

Copilot AI reviewed Nov 22, 2025

View reviewed changes

This was referenced Dec 1, 2025

chore(deps): bump github.com/gophercloud/gophercloud/v2 from 2.7.0 to 2.9.0 #511

Closed

chore(deps): bump golang.org/x/crypto from 0.40.0 to 0.45.0 #509

Closed

chore(deps): bump github.com/prometheus/common from 0.65.0 to 0.67.4 #512

Closed

vooon requested a review from Copilot December 3, 2025 10:53

Copilot AI reviewed Dec 3, 2025

View reviewed changes

Sharpz7 requested a review from Copilot December 4, 2025 02:43

Copilot started reviewing on behalf of Sharpz7 December 4, 2025 02:43 View session

Copilot finished reviewing on behalf of Sharpz7 December 4, 2025 02:43

Copilot AI reviewed Dec 4, 2025

View reviewed changes

Sharpz7 mentioned this pull request Dec 16, 2025

fix: Avoid paging in ListHypervisors #520

Closed

vooon force-pushed the port-to-gc-v2 branch from 2cc76dd to 003ae44 Compare December 29, 2025 09:26

vooon and others added 29 commits February 28, 2026 09:02

port(cache): migrate cache path to gophercloud v2

5e02943

Why: mechanical migration to gophercloud v2 APIs. Signed-off-by: Vladimir Ermakov <[email protected]>

port(exporter): remove remaining gophercloud v1 paths

b014a69

Why: mechanical framework migration to gophercloud v2. Signed-off-by: Vladimir Ermakov <[email protected]>

port(framework): standardize list function signatures

0925d98

Why: mechanical signature alignment for gophercloud v2. Signed-off-by: Vladimir Ermakov <[email protected]>

port(framework): add shared microversion setup helper

4ec04c7

Why: centralize microversion setup during gophercloud v2 porting. Signed-off-by: Vladimir Ermakov <[email protected]>

port(orchestration): migrate to gophercloud v2

c98bc80

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(keystone): migrate to gophercloud v2

987a970

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(nova): migrate to gophercloud v2

1f06d58

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(cinder): migrate to gophercloud v2

3ca8520

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(glance): migrate to gophercloud v2

0830559

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(neutron): migrate to gophercloud v2

a76800b

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(placement): migrate to gophercloud v2

b6a83c2

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(designate): migrate to gophercloud v2

dd57d6b

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(magnum): migrate to gophercloud v2

bd2781e

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(trove): migrate to gophercloud v2

44d4c99

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(octavia): migrate to gophercloud v2

54d66ed

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(manila): migrate to gophercloud v2

a41c329

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(gnocchi): migrate to gophercloud v2

cec7d45

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(object-store): migrate to gophercloud v2

18fd0d9

Why: mechanical service client migration. Signed-off-by: Vladimir Ermakov <[email protected]>

port(ironic): use shared microversion setup helper

c34697f

Why: move ironic microversion setup to the common framework helper. Signed-off-by: Vladimir Ermakov <[email protected]>

nova: add tenant_id to quota labels

b18bc82

Why: prevent project-name collisions (cardinality). Signed-off-by: Vladimir Ermakov <[email protected]>

neutron: add tenant_id to quota labels

ee51a76

Why: prevent project-name collisions (cardinality). Signed-off-by: Vladimir Ermakov <[email protected]>

neutron: add device_id on port metric

b01c026

Why: alert correlation improvement (cardinality). Signed-off-by: Vladimir Ermakov <[email protected]>

fix(nova): handle hypervisors pagination >1000

b024543

Fix openstack-exporter#519 which is proposed in openstack-exporter#520 Co-authored-by: Dejan Sanader <[email protected]> Signed-off-by: Vladimir Ermakov <[email protected]>

ironic: expose maintenance_reason label

4b9b227

Why: improve troubleshooting context for baremetal. Signed-off-by: Vladimir Ermakov <[email protected]>

ironic: expose update/provision timestamps

866a599

Why: add operational visibility for node lifecycle. Signed-off-by: Vladimir Ermakov <[email protected]>

placement: add resource generation metric

c2e2750

Why: expose provider generation for drift diagnostics. Signed-off-by: Vladimir Ermakov <[email protected]>

auto-detect enabled services in single-cloud

ba708cb

Why: select available services and fail fast on auth/catalog issues. Signed-off-by: Vladimir Ermakov <[email protected]>

fix(cache): fix content type header

81b14d6

Signed-off-by: Vladimir Ermakov <[email protected]>

docs: sync README metrics and CLI flags

3803bf4

Summary: - align README metrics table and CLI flags with current behavior - add exporter build info metric entry Why: Keep documentation in sync with implementation to avoid operator confusion. Signed-off-by: Vladimir Ermakov <[email protected]>

vooon force-pushed the port-to-gc-v2 branch from 7469d11 to 3803bf4 Compare February 28, 2026 08:02

Uh oh!

Conversation

vooon commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sharpz7 commented Oct 31, 2025

Uh oh!

Uh oh!

Sharpz7 commented Nov 4, 2025

Uh oh!

vooon commented Nov 10, 2025

Uh oh!

Sharpz7 commented Nov 12, 2025

Uh oh!

vooon commented Nov 12, 2025

Uh oh!

Sharpz7 commented Nov 13, 2025

Uh oh!

vooon commented Nov 19, 2025

Uh oh!

vooon commented Nov 20, 2025

Uh oh!

Sharpz7 commented Nov 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vooon commented Nov 22, 2025

Uh oh!

Sharpz7 commented Nov 24, 2025

Uh oh!

vooon commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vooon commented Oct 31, 2025 •

edited

Loading