fix: tabbar dnd invalid #4296

Ricbet · 2025-01-02T12:42:16Z

Types

🐛 Bug Fixes

Background or solution

Changelog

修复 tabbar 拖拽事件失效的问题

Summary by CodeRabbit

重构
- 改进了标签栏服务的状态管理机制
- 引入新的响应式编程方法，优化容器可见性和交互处理
- 通过可观察对象（Observables）更灵活地追踪和更新容器状态

coderabbitai · 2025-01-02T12:44:54Z

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.
warning eslint > @humanwhocodes/[email protected]: Use @eslint/config-array instead
warning eslint > @humanwhocodes/config-array > @humanwhocodes/[email protected]: Use @eslint/object-schema instead
warning eslint > file-entry-cache > flat-cache > [email protected]: Rimraf versions prior to v4 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > [email protected]: Glob versions prior to v9 are no longer supported
warning eslint > file-entry-cache > flat-cache > rimraf > glob > [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
warning eslint-import-resolver-typescript > [email protected]: Glob versions prior to v9 are no longer supported
error Couldn't find any versions for "@opensumi/ide-dev-tool" that matches "workspace:*"

变更概述

详细介绍

该变更主要修改了 TabbarService 类，引入了新的响应式编程方法来管理选项卡容器的可见性和状态。主要变更包括：

添加 doChangeViewEmitter 事件发射器
创建 shouldChangeView 可观察对象
引入 containerIdObs 可观察对象
重新定义 currentContainerId 属性的派生方式
修改 updateCurrentContainerId 和 doInsertTab 方法的实现

变更

文件路径	变更摘要
`packages/main-layout/src/browser/tabbar/tabbar.service.ts`	新增 `doChangeViewEmitter`、`shouldChangeView` 和 `containerIdObs`；重构 `currentContainerId`、`updateCurrentContainerId` 和 `doInsertTab` 方法

可能相关的 PR

fix: render tabbar correctly on initial load #3895：修改 TabbarService 类中容器 ID 的管理方式
fix: right panel container view #4178：更新选项卡组件的渲染逻辑
fix: immediately update with current component to handle initial badge #4238：增强选项卡栏的响应性

建议标签

🐞 bug

建议审阅者

erha19
bytemain
hacke2

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/main-layout/src/browser/tabbar/tabbar.service.ts (1)

78-83: 使用 Emitter 与 observableFromEventOpts 搭配更新视图的策略需关注潜在性能影响。
在 equalsFn: () => false 的情况下，任何触发都会强制视图更新，但目前看符合需求。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5923210 and 3cd7cc4.

📒 Files selected for processing (1)

packages/main-layout/src/browser/tabbar/tabbar.service.ts (4 hunks)

🔇 Additional comments (5)

packages/main-layout/src/browser/tabbar/tabbar.service.ts (5)

44-50: 导入可观察式工具库的改动看起来合理。
这些新增的工具类有助于统一管理可观察数据并提升代码可读性，无明显问题。

84-85: 初始化 containerIdObs 为 undefined 时，请确认使用场景是否做了非空判断。
确保在访问该值时不会发生空指针问题。

86-96: 通过 derivedOpts 结合 shouldChangeView 来动态更新 currentContainerId 的实现清晰可读。
此处逻辑明确，无需额外修改。

218-218: 使用 transaction 包裹 containerIdObs.set 有利于保证状态变更的原子性。
此实现方式正确，可在需要时统一管理派生更新。

714-714: 触发 doChangeViewEmitter.fire() 会通知所有观察者更新。
与前述可观察机制相配合，可确保拖拽事件后同步视图。

hacke2

LGTM

codecov · 2025-01-02T12:56:11Z

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.21%. Comparing base (5923210) to head (3cd7cc4).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/main-layout/src/browser/tabbar/tabbar.service.ts	84.61%	2 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4296   +/-   ##
=======================================
  Coverage   54.20%   54.21%           
=======================================
  Files        1634     1634           
  Lines       99907    99917   +10     
  Branches    21691    21699    +8     
=======================================
+ Hits        54159    54167    +8     
- Misses      38005    38007    +2     
  Partials     7743     7743

Flag	Coverage Δ
jsdom	`49.74% <84.61%> (+<0.01%)`	⬆️
node	`12.24% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: tabbar dnd invalid

3cd7cc4

Ricbet requested review from hacke2 and erha19 January 2, 2025 12:42

Ricbet self-assigned this Jan 2, 2025

opensumi bot added the 🐞 bug Something isn't working label Jan 2, 2025

coderabbitai bot reviewed Jan 2, 2025

View reviewed changes

hacke2 approved these changes Jan 2, 2025

View reviewed changes

hacke2 merged commit 7b8b351 into main Jan 2, 2025
13 checks passed

hacke2 deleted the fix/drag-invalid branch January 2, 2025 12:59

coderabbitai bot mentioned this pull request Jan 3, 2025

feat: terminal adds drag-and-drop #4300

Merged

1 task

coderabbitai bot mentioned this pull request Jan 22, 2025

Feat/move terminal #4330

Closed

11 tasks

coderabbitai bot mentioned this pull request Apr 8, 2025

fix: tabbar view can not be hidden #4507

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: tabbar dnd invalid #4296

fix: tabbar dnd invalid #4296

Uh oh!

Ricbet commented Jan 2, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 2, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

hacke2 left a comment

Uh oh!

codecov bot commented Jan 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: tabbar dnd invalid #4296

fix: tabbar dnd invalid #4296

Uh oh!

Conversation

Ricbet commented Jan 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types

Background or solution

Changelog

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 2, 2025

变更概述

详细介绍

变更

可能相关的 PR

建议标签

建议审阅者

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

hacke2 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Ricbet commented Jan 2, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jan 2, 2025 •

edited

Loading