Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: system prompt not working #4429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: system prompt not working #4429

merged 2 commits into from
Mar 4, 2025

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Mar 4, 2025

Types

  • πŸŽ‰ New Features
  • πŸ› Bug Fixes
  • πŸ“š Documentation Changes
  • πŸ’„ Code Style Changes
  • πŸ’„ Style Changes
  • πŸͺš Refactors
  • πŸš€ Performance Improvements
  • πŸ—οΈ Build System
  • ⏱ Tests
  • 🧹 Chores
  • Other Changes

Background or solution

Changelog

@opensumi opensumi bot added the 🐞 bug Something isn't working label Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 53.39%. Comparing base (8248022) to head (d67fac5).
Report is 4 commits behind head on v3.8.

Files with missing lines Patch % Lines
...s/ai-native/src/browser/chat/chat-proxy.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             v3.8    #4429      +/-   ##
==========================================
- Coverage   53.39%   53.39%   -0.01%     
==========================================
  Files        1657     1657              
  Lines      102188   102193       +5     
  Branches    22114    22114              
==========================================
  Hits        54563    54563              
- Misses      39616    39622       +6     
+ Partials     8009     8008       -1
Flag Coverage Ξ”
jsdom 48.90% <0.00%> (-0.01%) ⬇️
node 12.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

hacke2
hacke2 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@hacke2 hacke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hacke2 hacke2 merged commit 22ea056 into v3.8 Mar 4, 2025
10 checks passed
@hacke2 hacke2 deleted the fix/system-prompt-not-working branch March 4, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacke2 hacke2 hacke2 approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aaaaash @hacke2