feat: support chat reasoning #4470
Conversation
Walkthrough本次 PR 在多个模块中增加了对 “reasoning” 内容类型的支持。主要改动包括在聊天模型中引入新的类型 Changes
Sequence Diagram(s)sequenceDiagram
participant BLM as BaseLanguageModel
participant CRM as ChatResponseModel
participant CR as ChatReply
BLM->>CRM: 传递“reasoning”文本增量
CRM->>CRM: 检查最后响应是否为“reasoning”
CRM-->>CRM: 新增或更新响应部分
CRM->>CR: 更新响应文本（返回空字符串）
CR->>CR: 根据“reasoning”类型渲染特定内容
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
yarn install v1.22.22 ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/ai-native/src/browser/chat/chat-model.ts (2)
137-147: 处理 reasoning 内容的实现需要优化该实现处理了 'reasoning' 类型的内容，但存在几个潜在问题：
- 仅在创建新响应部分时移除
<think>标签，连接现有内容时没有处理此标签。如果在流式内容中间出现<think>标签可能导致不一致。- 缺乏对
progress.content的类型验证，假设它始终是字符串。建议修改为：
} else if (progress.kind === 'reasoning') { const lastResponsePart = this.#responseParts[responsePartLength]; if (!lastResponsePart || lastResponsePart.kind !== 'reasoning') { // 去掉开头的 <think> 标签 - this.#responseParts.push({ content: progress.content.replace(/^<think>/, ''), kind: 'reasoning' }); + // 确保 content 是字符串并处理标签 + const content = typeof progress.content === 'string' ? progress.content.replace(/^<think>/, '') : ''; + this.#responseParts.push({ content, kind: 'reasoning' }); } else { this.#responseParts[responsePartLength] = { - content: lastResponsePart.content + progress.content, + // 确保 content 是字符串并处理可能出现的标签 + content: lastResponsePart.content + (typeof progress.content === 'string' ? progress.content.replace(/^<think>/, '') : ''), kind: 'reasoning', }; }
141-141: 代码注释应使用英文// 去掉开头的 <think> 标签建议将中文注释改为英文，以保持代码库的一致性和可读性。
- // 去掉开头的 <think> 标签 + // Remove the <think> tag from the beginning
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/ai-native/src/browser/chat/chat-model.ts(5 hunks)packages/ai-native/src/browser/components/ChatReply.tsx(2 hunks)packages/ai-native/src/browser/components/components.module.less(1 hunks)packages/ai-native/src/node/base-language-model.ts(1 hunks)packages/core-common/src/types/ai-native/index.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
- GitHub Check: unittest (ubuntu-latest, 18.x, node)
- GitHub Check: build (ubuntu-latest, 20.x)
- GitHub Check: unittest (macos-latest, 18.x, jsdom)
- GitHub Check: build-windows
- GitHub Check: ubuntu-latest, Node.js 20.x
- GitHub Check: build (macos-latest, 20.x)
- GitHub Check: unittest (macos-latest, 18.x, node)
🔇 Additional comments (11)
packages/ai-native/src/browser/components/components.module.less (1)
545-549: 新增的样式类符合设计需求新增的
.reasoning样式类设计合理，用于显示推理内容。使用左侧边框和适当的内边距可以直观地区分推理内容与其他内容类型。代码使用了 CSS 变量var(--design-text-foreground)来保持颜色的一致性和主题兼容性。样式简洁明了，符合整体的设计风格。
packages/ai-native/src/node/base-language-model.ts (1)
188-192: 新增对 reasoning 类型的处理逻辑在
handleStreamingRequest方法中增加了对reasoning类型的处理。实现方式与其他类型处理保持一致，将reasoning类型的内容通过chatReadableStream.emitData方法发送给客户端。代码实现简洁有效，遵循了已有的代码模式，使系统能够正确处理推理内容流。
packages/ai-native/src/browser/components/ChatReply.tsx (2)
1-1: 导入 classnames 库添加了
classnames库的导入，用于条件性地应用 CSS 类。这是一个常用且实用的工具库，可以简化多个 CSS 类的条件组合。
317-322: 实现 reasoning 类型内容的渲染逻辑为
ChatReply组件添加了针对reasoning类型的条件分支，使用classnames库（作为cls导入）条件性地应用样式。当响应完成时，会添加collapse类，可能用于折叠或改变显示方式。渲染结构简洁明了，与其他内容类型的处理方式一致，提供了良好的用户体验。
packages/core-common/src/types/ai-native/index.ts (2)
404-407: 定义 IChatReasoning 接口新增的
IChatReasoning接口定义了推理内容的数据结构，包含content字符串属性和固定为'reasoning'的kind属性。接口定义清晰，符合现有的接口设计模式。
409-416: 扩展 IChatProgress 联合类型将新增的
IChatReasoning类型添加到IChatProgress联合类型中，使其成为可以在聊天进度中使用的有效内容类型。这种方式保持了类型系统的一致性，确保了新功能与现有系统的无缝集成。packages/ai-native/src/browser/chat/chat-model.ts (5)
9-9: 添加了新的接口导入新增的
IChatReasoning接口导入正确，这是支持聊天推理功能的基础类型。
37-38: 类型联合正确扩展将
IChatReasoning添加到IChatProgressResponseContent类型联合中，正确地扩展了系统支持的内容类型。
198-200: 正确处理 reasoning 类型的文本显示对于 'reasoning' 类型的内容返回空字符串是合理的，这表明推理内容不应该作为常规响应文本的一部分，而可能在 UI 中有特殊的展示方式。
407-407: 扩展了可处理的内容类型将 'reasoning' 添加到
basicKind数组中，使acceptResponseProgress方法能够正确处理这种新的内容类型。
5-13:✅ Verification successful
验证 IChatReasoning 接口的定义和实现
根据 AI 摘要，
IChatReasoning接口在packages/core-common/src/types/ai-native/index.ts中定义，包含content(字符串类型) 和kind(值为 'reasoning') 属性。建议确认该接口的完整定义与这里的使用方式一致。
🏁 Script executed:
#!/bin/bash # 检查 IChatReasoning 接口定义 cat packages/core-common/src/types/ai-native/index.ts | grep -A 10 "export interface IChatReasoning"Length of output: 308
接口定义验证通过，无需额外修改
检查显示
IChatReasoning接口在packages/core-common/src/types/ai-native/index.ts中正确定义为包含content: string和kind: 'reasoning'两个属性，与在chat-model.ts中的使用一致，无需进一步调整。
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4470 +/- ##
==========================================
- Coverage 53.24% 53.23% -0.01%
==========================================
Files 1663 1663
Lines 102608 102619 +11
Branches 22196 22209 +13
==========================================
+ Hits 54631 54632 +1
- Misses 39918 39926 +8
- Partials 8059 8061 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/ai-native/src/browser/components/ChatThinking.tsx (1)
35-45: 条件逻辑简化很好，但有一个小问题您已经简化了条件逻辑，不再检查
message的内容，仅检查children是否存在。然而在 useCallback 的依赖数组中，message仍被列为依赖项，尽管它不再在函数体中使用。建议从依赖数组中移除
message：const renderContent = useCallback(() => { if (!children) { if (CustomThinkingRender) { return <CustomThinkingRender thinkingText={thinkingText} />; } return <span className={styles.thinking_text}>{thinkingText || 'Thinking...'}</span>; } return children; - }, [message, children, thinkingText, CustomThinkingRender]); + }, [children, thinkingText, CustomThinkingRender]);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
packages/ai-native/src/browser/components/ChatReply.tsx(2 hunks)packages/ai-native/src/browser/components/components.module.less(1 hunks)packages/ai-native/src/browser/components/ChatReply.tsx(3 hunks)packages/ai-native/src/browser/components/ChatThinking.tsx(1 hunks)packages/ai-native/src/browser/components/components.module.less(1 hunks)packages/i18n/src/common/en-US.lang.ts(1 hunks)packages/i18n/src/common/zh-CN.lang.ts(1 hunks)packages/ai-native/src/browser/components/ChatReply.tsx(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/ai-native/src/browser/components/ChatReply.tsx
- packages/ai-native/src/browser/components/components.module.less
- packages/ai-native/src/browser/components/ChatReply.tsx
- packages/ai-native/src/browser/components/components.module.less
- packages/ai-native/src/browser/components/ChatReply.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
- GitHub Check: build (ubuntu-latest, 20.x)
- GitHub Check: unittest (ubuntu-latest, 18.x, node)
- GitHub Check: unittest (macos-latest, 18.x, jsdom)
- GitHub Check: build (macos-latest, 20.x)
- GitHub Check: build-windows
- GitHub Check: unittest (macos-latest, 18.x, node)
- GitHub Check: ubuntu-latest, Node.js 20.x
🔇 Additional comments (2)
packages/i18n/src/common/zh-CN.lang.ts (1)
1230-1230: 添加的本地化字符串看起来很好！这个新增的本地化字符串
'aiNative.chat.thinking': '深度思考中'与 PR 描述中提到的"支持聊天推理"功能保持一致，并且遵循了现有的命名模式。这将为用户提供更好的交互体验，让他们知道 AI 正在进行深度思考过程。packages/i18n/src/common/en-US.lang.ts (1)
1462-1462: 新增的本地化字符串看起来很好！这个添加支持了新的 reasoning 内容类型，为用户提供了更好的体验提示。
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
packages/ai-native/src/browser/components/ChatReply.tsx (1)
239-249:⚠️ Potential issue疑似遗留代码块无法正常生效。
这段useEffect中使用了disposableCollection，但没有显式调用或处理setCollapseThinkingIndexSet，代码逻辑似乎不完整，很可能是合并冲突后遗留的重复/无用片段。应尽快删除或完善，以避免维护成本与潜在Bug。您可考虑类似以下修正（若无逻辑需求，可直接移除该段）：
- useEffect(() => { - const disposableCollection = new DisposableCollection(); - - new Set( - request.response.responseContents... - ), - ); - }, [request.response.isComplete]);
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (11)
packages/ai-native/src/browser/components/ChatReply.tsx(2 hunks)packages/ai-native/src/browser/components/components.module.less(1 hunks)packages/ai-native/src/browser/components/ChatReply.tsx(3 hunks)packages/ai-native/src/browser/components/components.module.less(1 hunks)packages/i18n/src/common/en-US.lang.ts(1 hunks)packages/i18n/src/common/zh-CN.lang.ts(1 hunks)packages/ai-native/src/browser/components/ChatReply.tsx(1 hunks)packages/ai-native/src/browser/components/ChatReply.tsx(1 hunks)packages/ai-native/src/browser/components/components.module.less(1 hunks)packages/i18n/src/common/en-US.lang.ts(1 hunks)packages/i18n/src/common/zh-CN.lang.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (10)
- packages/ai-native/src/browser/components/components.module.less
- packages/ai-native/src/browser/components/ChatReply.tsx
- packages/ai-native/src/browser/components/ChatReply.tsx
- packages/i18n/src/common/en-US.lang.ts
- packages/i18n/src/common/en-US.lang.ts
- packages/i18n/src/common/zh-CN.lang.ts
- packages/ai-native/src/browser/components/ChatReply.tsx
- packages/ai-native/src/browser/components/components.module.less
- packages/i18n/src/common/zh-CN.lang.ts
- packages/ai-native/src/browser/components/components.module.less
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: unittest (ubuntu-latest, 18.x, jsdom)
- GitHub Check: unittest (ubuntu-latest, 18.x, node)
- GitHub Check: unittest (macos-latest, 18.x, jsdom)
- GitHub Check: unittest (macos-latest, 18.x, node)
- GitHub Check: ubuntu-latest, Node.js 20.x
- GitHub Check: build (ubuntu-latest, 20.x)
- GitHub Check: build (macos-latest, 20.x)
- GitHub Check: build-windows
🔇 Additional comments (3)
packages/ai-native/src/browser/components/ChatReply.tsx (3)
44-44: 引入本地化函数，便于国际化。
此处新增了localize的导入，在后续用到localize('aiNative.chat.thinking')，有助于界面文本的多语言支持。
229-237: 使用 Set 管理 reasoning 折叠状态的逻辑明确。
当请求未完成时默认不折叠；完成后对所有 reasoning 项进行折叠的策略看起来符合预期。如果后续要改变默认的折叠行为，可在这里加以调整。
368-368: 在依赖数组中加入折叠状态，确保组件及时刷新。
将collapseThinkingIndexSet加入依赖，能让 toggle 操作立刻触发重渲染，逻辑正确。
Types
Background or solution
feat: support chat reasoning
Changelog
feat: support chat reasoning
Summary by CodeRabbit