Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX - Request headers #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

FIX - Request headers #84

wants to merge 8 commits into from

Conversation

tysonlemire
Copy link

@tysonlemire tysonlemire commented Jun 19, 2024 •
edited
Loading

  1. The Request::getHeader was not returning an array when header values were set without using the Message::setHeaders method.
  2. Allow '0' as valid value for headers
  3. Correct getHeaders to return original header names as per Psr\Http\Message\MessageInterface

Additionally, the Psr7Tests for the Request were failing. Changed getRequestTarget to use isset instead of null.

tyson.lemire added 2 commits June 19, 2024 06:44
add failing test
f5b1447
- use message setHeaders method to construct request headers
1ec46ee 
- check requestTarget isset instead of null in getter
@tysonlemire tysonlemire changed the title FIX - Request header not reutnring array FIX - Request header not retuning array Jun 19, 2024
@tysonlemire tysonlemire changed the title FIX - Request header not retuning array FIX - Request header not returning array Jun 19, 2024
@tysonlemire tysonlemire changed the title FIX - Request header not returning array FIX - Request header fixes Jul 16, 2024
tyson.lemire added 2 commits July 16, 2024 11:28
@tysonlemire tysonlemire changed the title FIX - Request header fixes FIX - Request headers Jul 16, 2024
@KelseySheely KelseySheely mentioned this pull request Aug 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tysonlemire